Skip to content

refactor(ast): add AstKind for TSFunctionType#12287

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/07-15-refactor_ast_remove_astkind_for_tsfunctiontype_
Jul 15, 2025
Merged

refactor(ast): add AstKind for TSFunctionType#12287
graphite-app[bot] merged 1 commit intomainfrom
c/07-15-refactor_ast_remove_astkind_for_tsfunctiontype_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jul 15, 2025

No description provided.

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jul 15, 2025
@camc314 camc314 marked this pull request as ready for review July 15, 2025 12:13
Copy link
Contributor Author

camc314 commented Jul 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 15, 2025

CodSpeed Instrumentation Performance Report

Merging #12287 will not alter performance

Comparing c/07-15-refactor_ast_remove_astkind_for_tsfunctiontype_ (c025868) with main (633ba30)

Summary

✅ 34 untouched benchmarks

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 15, 2025
Copy link
Contributor Author

camc314 commented Jul 15, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/07-15-refactor_ast_remove_astkind_for_tsfunctiontype_ branch from f251ce2 to c025868 Compare July 15, 2025 12:28
@graphite-app graphite-app bot merged commit c025868 into main Jul 15, 2025
24 checks passed
@graphite-app graphite-app bot deleted the c/07-15-refactor_ast_remove_astkind_for_tsfunctiontype_ branch July 15, 2025 12:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 15, 2025
@Dunqing
Copy link
Member

Dunqing commented Jul 15, 2025

The PR title confused me, I thought that you were removing AstKind::TSFunctionType

@camc314 camc314 changed the title refactor(ast): remove AstKind for TSFunctionType refactor(ast): add AstKind for TSFunctionType Jul 15, 2025
@camc314
Copy link
Contributor Author

camc314 commented Jul 15, 2025

oops, i've been in the habit so much of the ast kind being removed, i didn't realize i had actually added it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants