Skip to content

refactor(ast): shorten CommentNewlines methods#11152

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-19-refactor_ast_shorten_commentnewlines_methods
May 19, 2025
Merged

refactor(ast): shorten CommentNewlines methods#11152
graphite-app[bot] merged 1 commit intomainfrom
05-19-refactor_ast_shorten_commentnewlines_methods

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 19, 2025

Follow-on after #11096. Pure refactor. Shorten the setter methods. Also move them to after the getters and in same order.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 19, 2025
Copy link
Member Author

overlookmotel commented May 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 19, 2025 09:50
@overlookmotel overlookmotel requested a review from camchenry May 19, 2025 09:53
@overlookmotel
Copy link
Member Author

overlookmotel commented May 19, 2025

@camchenry The fact that I've made 3 follow-up PRs doesn't indicate I think your PR was riddled with problems. They're all just nits. I just prefer to take a "each commit does one thing" approach.

@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Instrumentation Performance Report

Merging #11152 will improve performances by 3.42%

Comparing 05-19-refactor_ast_shorten_commentnewlines_methods (20a4a8c) with 05-18-refactor_ast_rename_commentnewlines_fields (58c7de6)

Summary

⚡ 1 improvements
✅ 33 untouched benchmarks
🆕 4 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[binder.ts] N/A 146.5 ms N/A
🆕 linter[cal.com.tsx] N/A 1.3 s N/A
🆕 linter[react.development.js] N/A 53.7 ms N/A
mangler[cal.com.tsx] 3 ms 2.9 ms +3.42%

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 19, 2025
Copy link
Member

Boshen commented May 19, 2025

Merge activity

Follow-on after #11096. Pure refactor. Shorten the setter methods. Also move them to after the getters and in same order.
@graphite-app graphite-app bot force-pushed the 05-18-refactor_ast_rename_commentnewlines_fields branch from c509439 to 58c7de6 Compare May 19, 2025 11:44
@graphite-app graphite-app bot force-pushed the 05-19-refactor_ast_shorten_commentnewlines_methods branch from 25aa2e1 to 20a4a8c Compare May 19, 2025 11:45
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 19, 2025
Base automatically changed from 05-18-refactor_ast_rename_commentnewlines_fields to main May 19, 2025 11:52
@graphite-app graphite-app bot merged commit 20a4a8c into main May 19, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 05-19-refactor_ast_shorten_commentnewlines_methods branch May 19, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants