Skip to content

refactor(ast): shorten CommentNewlines methods #11152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
May 19, 2025
Merged

refactor(ast): shorten CommentNewlines methods #11152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions crates/oxc_ast/src/ast/comment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,26 +249,6 @@ impl Comment {
self.annotation == CommentAnnotation::CoverageIgnore && self.is_leading()
}

/// Sets the state of `newlines` to include/exclude a newline after the comment.
#[inline]
pub fn set_followed_by_newline(&mut self, followed_by_newline: bool) {
if followed_by_newline {
self.newlines.insert(CommentNewlines::Trailing);
} else {
self.newlines.remove(CommentNewlines::Trailing);
}
}

/// Sets the state of `newlines` to include/exclude a newline before the comment.
#[inline]
pub fn set_preceded_by_newline(&mut self, preceded_by_newline: bool) {
if preceded_by_newline {
self.newlines.insert(CommentNewlines::Leading);
} else {
self.newlines.remove(CommentNewlines::Leading);
}
}

/// Returns `true` if this comment is preceded by a newline.
#[inline]
pub fn preceded_by_newline(self) -> bool {
Expand All @@ -280,4 +260,16 @@ impl Comment {
pub fn followed_by_newline(self) -> bool {
self.newlines.contains(CommentNewlines::Trailing)
}

/// Sets the state of `newlines` to include/exclude a newline before the comment.
#[inline]
pub fn set_preceded_by_newline(&mut self, preceded_by_newline: bool) {
self.newlines.set(CommentNewlines::Leading, preceded_by_newline);
}

/// Sets the state of `newlines` to include/exclude a newline after the comment.
#[inline]
pub fn set_followed_by_newline(&mut self, followed_by_newline: bool) {
self.newlines.set(CommentNewlines::Trailing, followed_by_newline);
}
}
Loading