refactor(ast): inline Comment newline flags setters#11150
Merged
graphite-app[bot] merged 1 commit intomainfrom May 19, 2025
Merged
refactor(ast): inline Comment newline flags setters#11150graphite-app[bot] merged 1 commit intomainfrom
Comment newline flags setters#11150graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-ast
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11150 will improve performances by 4.19%Comparing Summary
Benchmarks breakdown
|
Member
Author
|
This shows +3% on one of minifier benchmarks! But I assume that's erroneous - our benchmarks have become very noisy recently. |
Contributor
Merge activity
|
Follow-on after #11096. Add `#[inline]` to these trivial functions. Usually they're called with a static value, so if they're inlined compiler will be able to remove the branch. Probably compiler would inline these anyway as they're so small, but just to make sure.
graphite-app
bot
force-pushed
the
05-18-refactor_ast_inline_comment_newline_flags_setters
branch
from
82e4dd2 to
e5438dc
Compare
graphite-app
bot
deleted the
05-18-refactor_ast_inline_comment_newline_flags_setters
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #11096. Add
#[inline]to these trivial functions. Usually they're called with a static value, so if they're inlined compiler will be able to remove the branch.Probably compiler would inline these anyway as they're so small, but just to make sure.