refactor(ast): rename CommentNewlines fields#11151
Merged
graphite-app[bot] merged 1 commit intomainfrom May 19, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-parser
CodSpeed Instrumentation Performance ReportMerging #11151 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
Follow-on after #11096. Pure refactor. Our naming convention for `bitflags!` fields is not completely consistent, but mostly we use mixed case. Rename them to match that style. Also, remove the `LEADING_AND_TRAILING` option, as it's only used in tests.
graphite-app
bot
force-pushed
the
05-18-refactor_ast_inline_comment_newline_flags_setters
branch
from
82e4dd2 to
e5438dc
Compare
graphite-app
bot
force-pushed
the
05-18-refactor_ast_rename_commentnewlines_fields
branch
from
c509439 to
58c7de6
Compare
Base automatically changed from
05-18-refactor_ast_inline_comment_newline_flags_setters
to
main
May 19, 2025 11:50
graphite-app
bot
deleted the
05-18-refactor_ast_rename_commentnewlines_fields
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #11096. Pure refactor. Our naming convention for
bitflags!fields is not completely consistent, but mostly we use mixed case. Rename them to match that style.Also, remove the
LEADING_AND_TRAILINGoption, as it's only used in tests.