refactor(transformer/refresh): do not unnecessarily consume Vec

[overlookmotel]

Follow-on after #10656.

There's no need to consume self.registrations because we only need a reference to binding (BoundIdentifier), and the persistent_id is an Atom, which is Copy.

Just iterate over &self.registrations.

[overlookmotel]

• perf(transformer/refresh): RefreshIdentifierResolver::parse search string for . only once #10719
• perf(transformer/refresh): remove temp Vec #10713
• refactor(transformer/refresh): do not unnecessarily consume Vec #10712 👈 (View in Graphite)
• perf(transformer/refresh): reuse existing Atom #10709
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10712 will not alter performance

_{Comparing 04-29-refactor_transformer_refresh_do_not_unnecessarily_consume_vec_ (c4a5dba) with main (2aa3c4c)}

Summary

✅ 33 untouched benchmarks
🆕 3 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	3.1 s	N/A

[Boshen]

Merge activity

• Apr 30, 6:10 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 30, 6:10 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Apr 30, 6:18 AM EDT: Merged by the Graphite merge queue.