Skip to content

perf(transformer/refresh): reuse existing Atom#10709

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-29-perf_transformer_refresh_reuse_existing_atom_
Apr 30, 2025
Merged

perf(transformer/refresh): reuse existing Atom#10709
graphite-app[bot] merged 1 commit intomainfrom
04-29-perf_transformer_refresh_reuse_existing_atom_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 30, 2025

Don't create a new Atom and copy string data, when there's an existing Atom we can use.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 30, 2025
Copy link
Member Author

overlookmotel commented Apr 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review April 30, 2025 07:14
@overlookmotel overlookmotel requested a review from Dunqing as a code owner April 30, 2025 07:14
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 30, 2025

CodSpeed Instrumentation Performance Report

Merging #10709 will not alter performance

Comparing 04-29-perf_transformer_refresh_reuse_existing_atom_ (2aa3c4c) with main (7d8efd8)

Summary

✅ 33 untouched benchmarks
🆕 3 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3.1 s N/A

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 30, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 30, 2025

Merge activity

Don't create a new `Atom` and copy string data, when there's an existing `Atom` we can use.
@graphite-app graphite-app bot force-pushed the 04-29-perf_transformer_refresh_reuse_existing_atom_ branch from aa11464 to 2aa3c4c Compare April 30, 2025 10:10
@graphite-app graphite-app bot merged commit 2aa3c4c into main Apr 30, 2025
26 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 30, 2025
@graphite-app graphite-app bot deleted the 04-29-perf_transformer_refresh_reuse_existing_atom_ branch April 30, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants