Skip to content

refactor(transformer/refresh): do not unnecessarily consume Vec #10712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 30, 2025
Merged

refactor(transformer/refresh): do not unnecessarily consume Vec #10712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/oxc_transformer/src/jsx/refresh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::{collections::hash_map::Entry, mem};
use std::collections::hash_map::Entry;

use base64::{
encoded_len as base64_encoded_len,
Expand Down Expand Up @@ -157,7 +157,7 @@ impl<'a> Traverse<'a> for ReactRefresh<'a, '_> {

let mut variable_declarator_items = ctx.ast.vec_with_capacity(self.registrations.len());
let mut new_statements = ctx.ast.vec_with_capacity(self.registrations.len());
for (binding, persistent_id) in mem::take(&mut self.registrations) {
for (binding, persistent_id) in &self.registrations {
variable_declarator_items.push(ctx.ast.variable_declarator(
SPAN,
VariableDeclarationKind::Var,
Expand All @@ -169,7 +169,7 @@ impl<'a> Traverse<'a> for ReactRefresh<'a, '_> {
let callee = self.refresh_reg.to_expression(ctx);
let arguments = ctx.ast.vec_from_array([
Argument::from(binding.create_read_expression(ctx)),
Argument::from(ctx.ast.expression_string_literal(SPAN, persistent_id, None)),
Argument::from(ctx.ast.expression_string_literal(SPAN, *persistent_id, None)),
]);
new_statements.push(ctx.ast.statement_expression(
SPAN,
Expand Down
Loading