perf(transformer/refresh): remove temp Vec#10713
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 30, 2025
Merged
Conversation
github-actions
bot
added
A-transformer
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10713 will not alter performanceComparing Summary
Benchmarks breakdown
|
graphite-app
bot
changed the base branch from
04-29-refactor_transformer_refresh_do_not_unnecessarily_consume_vec_
to
graphite-base/10713
graphite-app
bot
force-pushed
the
04-29-perf_transformer_refresh_remove_temp_vec_
branch
from
ed96fdb to
47a0325
Compare
graphite-app
bot
force-pushed
the
graphite-base/10713
branch
from
7fd3575 to
c4a5dba
Compare
graphite-app
bot
force-pushed
the
04-29-perf_transformer_refresh_remove_temp_vec_
branch
from
47a0325 to
5c69b19
Compare
overlookmotel
force-pushed
the
04-29-perf_transformer_refresh_remove_temp_vec_
branch
from
5c69b19 to
b02d103
Compare
Contributor
Merge activity
|
Follow-on after #10656. Remove the temporary `Vec` `new_statements`. Append new statements directly to `program.body` instead. We get around the fact that the `VariableDeclaration` has to be inserted first by initially pushing a `VariableDeclaration` with no declarators, and then setting its declarators at the end.
graphite-app
bot
force-pushed
the
04-29-perf_transformer_refresh_remove_temp_vec_
branch
from
b02d103 to
9e557cf
Compare
graphite-app
bot
deleted the
04-29-perf_transformer_refresh_remove_temp_vec_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #10656.
Remove the temporary
Vecnew_statements. Append new statements directly toprogram.bodyinstead.We get around the fact that the
VariableDeclarationhas to be inserted first by initially pushing aVariableDeclarationwith no declarators, and then setting its declarators at the end.