Skip to content

feat(transformer): eliminate ExportSpecifier where refers to a declare declaration#10356

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration
Apr 11, 2025
Merged

feat(transformer): eliminate ExportSpecifier where refers to a declare declaration#10356
graphite-app[bot] merged 1 commit intomainfrom
04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 11, 2025

Copy link
Member Author

Dunqing commented Apr 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing force-pushed the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch from f5bdc37 to 0081548 Compare April 11, 2025 02:05
@Dunqing Dunqing force-pushed the 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration branch from 88ff365 to b6fe6ce Compare April 11, 2025 02:05
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Instrumentation Performance Report

Merging #10356 will improve performances by 3.6%

Comparing 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration (08a1d4b) with main (1a37e3f)

Summary

⚡ 1 improvements
✅ 35 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 8.1 ms 7.8 ms +3.6%

@Dunqing Dunqing force-pushed the 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration branch 2 times, most recently from 69792a8 to efaa721 Compare April 11, 2025 07:15
@Dunqing Dunqing force-pushed the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch from 0081548 to d67b558 Compare April 11, 2025 07:15
@Dunqing Dunqing marked this pull request as ready for review April 11, 2025 08:36
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 11, 2025 08:36
@Dunqing Dunqing force-pushed the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch from d67b558 to f41abc2 Compare April 11, 2025 09:48
@Dunqing Dunqing force-pushed the 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration branch from efaa721 to b327319 Compare April 11, 2025 09:48
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
Copy link
Member

Boshen commented Apr 11, 2025

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
@graphite-app graphite-app bot force-pushed the 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method branch from f41abc2 to 4c14d0b Compare April 11, 2025 10:16
@graphite-app graphite-app bot requested a review from Boshen as a code owner April 11, 2025 10:16
@graphite-app graphite-app bot force-pushed the 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration branch from b327319 to 08a1d4b Compare April 11, 2025 10:17
Base automatically changed from 04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method to main April 11, 2025 10:26
@graphite-app graphite-app bot merged commit 08a1d4b into main Apr 11, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-11-feat_transformer_remove_exportspecifier_where_refers_to_a_declare_declaration branch April 11, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transformer: export {} with declare declaration [Bug]: Unsupported declare export

2 participants