fix(semantic): do not declare a Symbol for an ModuleDeclaration where the id is not a BindingIdentifier

[Dunqing]

In previous implementations, a symbol was declared for ModuleDeclaration but only inserted when name was a BindingIdentifier. This is incorrect and also causes a potential performance impact. See https://github.com/oxc-project/oxc/blob/bae53b9606b62fce58b4101497849997b0dc07b3/crates/oxc_semantic/src/stats.rs.

So we should only declare a symbol when its name is a BindingIdentifier because only BindingIdentifier can be inserted with a symbol ID.

[Dunqing]

• refactor(transformer/typescript): remove unnecessary specific handling of TSModuleDeclaration transformation #10359
• refactor(transformer/typescript): do not need to go through TSModuleDeclaration if is a NamespaceModule #10366
• test(transformer/typescript): override namespace/empty-removed test #10365
• feat(transformer): eliminate ExportSpecifier where refers to a declare declaration #10356
• refactor(transformer/typescript): simplify TypeScriptAnnotations::has_value_reference method #10349
• feat(semantic): add SymbolFlags::Ambient for declaration with declare modifier #10355
• fix(semantic): incorrect SymbolFlags of TSModuleDeclaration #10350
• fix(semantic): do not declare a Symbol for an ModuleDeclaration where the id is not a BindingIdentifier #10343 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10343 will not alter performance

_{Comparing 04-10-refactor_semantic_simplify_bind_logic_for_tsmoduledeclaration (c37f048) with main (4a6bb21)}

Summary

✅ 36 untouched benchmarks

[graphite-app]

Merge activity

• Apr 11, 5:58 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Apr 11, 6:11 AM EDT: Merged by the Graphite merge queue.