refactor(transformer/typescript): simplify TypeScriptAnnotations::has_value_reference method - #10349
Merged
Conversation
Member
Author
This was referenced Apr 10, 2025
CodSpeed Instrumentation Performance ReportMerging #10349 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method
branch
from
April 10, 2025 11:36
8790921 to
e82bd5c
Compare
Dunqing
force-pushed
the
04-10-refactor_semantic_simplify_bind_logic_for_tsmoduledeclaration
branch
from
April 10, 2025 11:36
678454b to
0a2fed4
Compare
Dunqing
changed the base branch from
04-10-refactor_semantic_simplify_bind_logic_for_tsmoduledeclaration
to
graphite-base/10349
April 11, 2025 01:54
Dunqing
force-pushed
the
04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method
branch
from
April 11, 2025 01:54
e82bd5c to
f5bdc37
Compare
Dunqing
changed the base branch from
graphite-base/10349
to
04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier
April 11, 2025 01:54
This was referenced Apr 11, 2025
Dunqing
force-pushed
the
04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method
branch
2 times, most recently
from
April 11, 2025 07:15
0081548 to
d67b558
Compare
Dunqing
force-pushed
the
04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier
branch
from
April 11, 2025 07:15
946b095 to
40c2330
Compare
Dunqing
marked this pull request as ready for review
April 11, 2025 08:34
This was referenced Apr 11, 2025
Dunqing
changed the base branch from
04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier
to
graphite-base/10349
April 11, 2025 09:47
Dunqing
force-pushed
the
04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method
branch
from
April 11, 2025 09:48
d67b558 to
f41abc2
Compare
Dunqing
force-pushed
the
graphite-base/10349
branch
from
April 11, 2025 09:48
40c2330 to
896f560
Compare
Dunqing
changed the base branch from
graphite-base/10349
to
04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier
April 11, 2025 09:48
graphite-app
Bot
changed the base branch from
04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier
to
graphite-base/10349
April 11, 2025 09:59
Contributor
Merge activity
|
…s_value_reference` method (#10349) We already have a `BindingIdentifier`, so we don't need to get the symbol ID by `get_root_binding` again.
graphite-app
Bot
force-pushed
the
04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method
branch
from
April 11, 2025 10:16
f41abc2 to
4c14d0b
Compare
graphite-app
Bot
deleted the
04-10-refactor_transformer_typescript_simplify_typescriptannotations_has_value_reference_method
branch
April 11, 2025 10:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We already have a
BindingIdentifier, so we don't need to get the symbol ID byget_root_bindingagain.