feat(semantic): add SymbolFlags::Ambient for declaration with declare modifier#10355
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 11, 2025
Conversation
SymbolFlags::ambient for declaration with declare modifierSymbolFlags::Ambient for declaration with declare modifier
Member
Author
CodSpeed Instrumentation Performance ReportMerging #10355 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
946b095 to
40c2330
Compare
This was referenced Apr 11, 2025
40c2330 to
896f560
Compare
5ef7f81 to
ec0539d
Compare
Contributor
Merge activity
|
ec0539d to
dd2aef0
Compare
896f560 to
1a37e3f
Compare
Base automatically changed from
04-10-fix_semantic_incorrect_symbolflags_of_tsmoduledeclaration
to
main
April 11, 2025 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of #7951.
After we have a
SymbolFlags::Ambientwithin a Symbol that is declared by thedeclaremodifier, we can determine whether to remove anExportSpecifierby tracing its referent and examining itsSymbolFlags.