Skip to content

feat(semantic): add SymbolFlags::Ambient for declaration with declare modifier#10355

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier
Apr 11, 2025
Merged

feat(semantic): add SymbolFlags::Ambient for declaration with declare modifier#10355
graphite-app[bot] merged 1 commit intomainfrom
04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 11, 2025

Part of #7951.

After we have a SymbolFlags::Ambient within a Symbol that is declared by the declare modifier, we can determine whether to remove an ExportSpecifier by tracing its referent and examining its SymbolFlags.

@Dunqing Dunqing changed the title feat(semantic): add SymbolFlags::ambient for declaration with declare modifier feat(semantic): add SymbolFlags::Ambient for declaration with declare modifier Apr 11, 2025
Copy link
Member Author

Dunqing commented Apr 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Instrumentation Performance Report

Merging #10355 will create unknown performance changes

Comparing 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier (1a37e3f) with 04-10-fix_semantic_incorrect_symbolflags_of_tsmoduledeclaration (dd2aef0)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.2 ms N/A
🆕 formatter[antd.js] N/A 8.1 ms N/A
🆕 formatter[react.development.js] N/A 51.7 µs N/A
🆕 formatter[typescript.js] N/A 345.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.4 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.4 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.9 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 15.9 ms N/A
🆕 mangler[react.development.js] N/A 289.6 µs N/A
🆕 mangler[typescript.js] N/A 39.4 ms N/A
🆕 minifier[antd.js] N/A 165.3 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.2 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing Dunqing force-pushed the 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier branch from 946b095 to 40c2330 Compare April 11, 2025 07:15
@Dunqing Dunqing marked this pull request as ready for review April 11, 2025 08:30
@Dunqing Dunqing requested a review from Boshen as a code owner April 11, 2025 08:30
@Dunqing Dunqing force-pushed the 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier branch from 40c2330 to 896f560 Compare April 11, 2025 09:47
@Dunqing Dunqing force-pushed the 04-10-fix_semantic_incorrect_symbolflags_of_tsmoduledeclaration branch from 5ef7f81 to ec0539d Compare April 11, 2025 09:47
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 11, 2025

Merge activity

…are` modifier (#10355)

Part of #7951.

After we have a `SymbolFlags::Ambient` within a Symbol that is declared by the `declare` modifier,  we can determine whether to remove an `ExportSpecifier` by tracing its referent and examining its `SymbolFlags`.
@graphite-app graphite-app bot force-pushed the 04-10-fix_semantic_incorrect_symbolflags_of_tsmoduledeclaration branch from ec0539d to dd2aef0 Compare April 11, 2025 09:59
@graphite-app graphite-app bot force-pushed the 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier branch from 896f560 to 1a37e3f Compare April 11, 2025 09:59
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
Base automatically changed from 04-10-fix_semantic_incorrect_symbolflags_of_tsmoduledeclaration to main April 11, 2025 10:12
@graphite-app graphite-app bot merged commit 1a37e3f into main Apr 11, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-11-feat_semantic_add_symbolflags_ambient_for_declaration_with_declare_modifier branch April 11, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant