-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Patch fix: updated makefile to include unit-test and unit-test-attestor and cont… #2366
Conversation
Integration tests success for |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2366 +/- ##
=======================================
Coverage 40.61% 40.61%
=======================================
Files 112 112
Lines 8831 8831
=======================================
Hits 3587 3587
Misses 4984 4984
Partials 260 260 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just sign-off your commit to take care of the DCO check
hi @spencerschrock , friendly reminder to label this PR with "hacktoberfest-accepted" before merging it in. thanks! |
Integration tests success for |
Integration tests success for |
Integration tests success for |
Integration tests success for |
Integration tests success for |
I see signoffs in your latest commits, thanks! But the DCO bot will fail until all commits are signed off, so you'll need to rebase. |
9c4257e
to
aab5a1d
Compare
Integration tests success for |
…ributing doc to include e2e-pat Signed-off-by: Dave Banerjee <[email protected]>
Signed-off-by: Dave Banerjee <[email protected]>
Integration tests success for |
Integration tests success for |
…estor and cont… (ossf#2366) * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <[email protected]> * updated docs Signed-off-by: Dave Banerjee <[email protected]> Signed-off-by: Dave Banerjee <[email protected]> Co-authored-by: Dave Banerjee <[email protected]> Signed-off-by: latortuga <latortugaaaa>
…estor and cont… (ossf#2366) * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <[email protected]> * updated docs Signed-off-by: Dave Banerjee <[email protected]> Signed-off-by: Dave Banerjee <[email protected]> Co-authored-by: Dave Banerjee <[email protected]> Signed-off-by: nathaniel.wert <[email protected]>
…estor and cont… (ossf#2366) * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <[email protected]> * updated docs Signed-off-by: Dave Banerjee <[email protected]> Signed-off-by: Dave Banerjee <[email protected]> Co-authored-by: Dave Banerjee <[email protected]> Signed-off-by: nathaniel.wert <[email protected]>
…estor and cont… (ossf#2366) * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <[email protected]> * updated docs Signed-off-by: Dave Banerjee <[email protected]> Signed-off-by: Dave Banerjee <[email protected]> Co-authored-by: Dave Banerjee <[email protected]>
…ributing doc to include e2e-pat
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Running make all now runs unit-test and unit-test-attestor
Which issue(s) this PR fixes
This PR fixes: #2330
Fixes #2330
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)