Skip to content

Commit d7c23c9

Browse files
dvbnrgDave Banerjee
and
Dave Banerjee
authored
📖 Patch fix: updated makefile to include unit-test and unit-test-attestor and cont… (#2366)
* updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <[email protected]> * updated docs Signed-off-by: Dave Banerjee <[email protected]> Signed-off-by: Dave Banerjee <[email protected]> Co-authored-by: Dave Banerjee <[email protected]>
1 parent bd0de45 commit d7c23c9

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

CONTRIBUTING.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,11 @@ Following the targets that can be used to test your changes locally.
102102
| Command | Description | Is called in the CI? |
103103
| -------- | -------------------------------------------------- | -------------------- |
104104
| make all | Runs go test,golangci lint checks, fmt, go mod tidy| yes |
105-
| make e2e | Runs e2e tests | yes |
105+
| make e2e-pat | Runs e2e tests | yes |
106+
107+
Make sure to signoff your commits before submitting a pull request.
108+
109+
https://docs.pi-hole.net/guides/github/how-to-signoff/
106110

107111
## Permission for GitHub personal access tokens
108112

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ install: $(GOLANGCI_LINT) \
8484
##@ Build
8585
################################## make all ###################################
8686
all: ## Runs build, test and verify
87-
all-targets = build check-linter validate-docs add-projects validate-projects
87+
all-targets = build unit-test unit-test-attestor check-linter validate-docs add-projects validate-projects
8888
.PHONY: all all-targets-update-dependencies $(all-targets) update-dependencies tree-status
8989
all-targets-update-dependencies: $(all-targets) | update-dependencies
9090
all: update-dependencies all-targets-update-dependencies tree-status

0 commit comments

Comments
 (0)