📖 Patch fix: updated makefile to include unit-test and unit-test-att…

…estor and cont… (ossf#2366) * updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat Signed-off-by: Dave Banerjee <[email protected]> * updated docs Signed-off-by: Dave Banerjee <[email protected]> Signed-off-by: Dave Banerjee <[email protected]> Co-authored-by: Dave Banerjee <[email protected]> Signed-off-by: nathaniel.wert <[email protected]>
N8BWert · Nov 28, 2022 · 4d69417 · 4d69417
1 parent 450f428
commit 4d69417
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -102,7 +102,11 @@ Following the targets that can be used to test your changes locally.
 | Command  | Description                                        | Is called in the CI? |
 | -------- | -------------------------------------------------- | -------------------- |
 | make all | Runs go test,golangci lint checks, fmt, go mod tidy| yes                  |
-| make e2e | Runs e2e tests                                     | yes                  |
+| make e2e-pat | Runs e2e tests                                     | yes                  |
+
+Make sure to signoff your commits before submitting a pull request.
+
+https://docs.pi-hole.net/guides/github/how-to-signoff/
 
 ## Permission for GitHub personal access tokens
 

diff --git a/Makefile b/Makefile
@@ -84,7 +84,7 @@ install: $(GOLANGCI_LINT) \
 ##@ Build
 ################################## make all ###################################
 all:  ## Runs build, test and verify
-all-targets = build check-linter validate-docs add-projects validate-projects
+all-targets = build unit-test unit-test-attestor check-linter validate-docs add-projects validate-projects
 .PHONY: all all-targets-update-dependencies $(all-targets) update-dependencies tree-status
 all-targets-update-dependencies: $(all-targets) | update-dependencies
 all: update-dependencies all-targets-update-dependencies tree-status