Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Patch fix: updated makefile to include unit-test and unit-test-attestor and cont… #2366

Merged
merged 3 commits into from
Oct 20, 2022
Merged

📖 Patch fix: updated makefile to include unit-test and unit-test-attestor and cont… #2366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef29781
updated makefile to include unit-test and unit-test-attestor and cont…
Oct 18, 2022
623b07f
updated docs
Oct 19, 2022
c1e92c1
Merge branch 'main' into issue-2330
spencerschrock Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ Following the targets that can be used to test your changes locally.
| Command | Description | Is called in the CI? |
| -------- | -------------------------------------------------- | -------------------- |
| make all | Runs go test,golangci lint checks, fmt, go mod tidy| yes |
| make e2e | Runs e2e tests | yes |
| make e2e-pat | Runs e2e tests | yes |

Make sure to signoff your commits before submitting a pull request.

https://docs.pi-hole.net/guides/github/how-to-signoff/

## Permission for GitHub personal access tokens

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ install: $(GOLANGCI_LINT) \
##@ Build
################################## make all ###################################
all: ## Runs build, test and verify
all-targets = build check-linter validate-docs add-projects validate-projects
all-targets = build unit-test unit-test-attestor check-linter validate-docs add-projects validate-projects
.PHONY: all all-targets-update-dependencies $(all-targets) update-dependencies tree-status
all-targets-update-dependencies: $(all-targets) | update-dependencies
all: update-dependencies all-targets-update-dependencies tree-status
Expand Down