fix(authz): Return deny on GetDecision if resource attribute lookup returns not found #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihalcik-virtru
previously approved these changes
Jun 11, 2024
patmantru
approved these changes
Jun 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 2, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.8](service/v0.4.7...service/v0.4.8) (2024-07-02) ### Features * **policy:** add index to fqn column in attribute_fqns table ([#1035](#1035)) ([1b0cf38](1b0cf38)), closes [#1053](#1053) * **policy:** add unsafe attribute RPC db connectivity ([#1022](#1022)) ([fbc02f3](fbc02f3)) * **policy:** attribute values unsafe actions db connectivity ([#1030](#1030)) ([4a30426](4a30426)) * **policy:** register unsafe service in platform ([#1066](#1066)) ([b7796cd](b7796cd)) ### Bug Fixes * **authz:** Return deny on GetDecision if resource attribute lookup returns not found ([#962](#962)) ([7dea640](7dea640)) * **core:** Autobump service ([#1072](#1072)) ([409df67](409df67)) * **core:** Autobump service ([#1079](#1079)) ([10138d2](10138d2)) * **core:** Autobump service ([#1084](#1084)) ([968883e](968883e)) * **core:** database clients pooling improvements ([#1047](#1047)) ([8193cec](8193cec)) * **core:** swap out internal issuer for external issuer endpoint ([#1027](#1027)) ([c3828d0](c3828d0)) * **core:** update casbin policy to allow authorization service ([#1041](#1041)) ([552e970](552e970)) * **policy:** provide ns and val fqns back on list attributes response ([#1050](#1050)) ([1be04f6](1be04f6)), closes [#1052](#1052) * **policy:** rename unsafe rpcs for aligned casbin action determination ([#1067](#1067)) ([7861e4a](7861e4a)) * **policy:** run migrations on db only once for all policy services ([#1040](#1040)) ([db4f06f](db4f06f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
jakedoublev
pushed a commit
that referenced
this pull request
Jul 7, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.8](service/v0.4.7...service/v0.4.8) (2024-07-02) ### Features * **policy:** add index to fqn column in attribute_fqns table ([#1035](#1035)) ([1b0cf38](1b0cf38)), closes [#1053](#1053) * **policy:** add unsafe attribute RPC db connectivity ([#1022](#1022)) ([fbc02f3](fbc02f3)) * **policy:** attribute values unsafe actions db connectivity ([#1030](#1030)) ([4a30426](4a30426)) * **policy:** register unsafe service in platform ([#1066](#1066)) ([b7796cd](b7796cd)) ### Bug Fixes * **authz:** Return deny on GetDecision if resource attribute lookup returns not found ([#962](#962)) ([7dea640](7dea640)) * **core:** Autobump service ([#1072](#1072)) ([409df67](409df67)) * **core:** Autobump service ([#1079](#1079)) ([10138d2](10138d2)) * **core:** Autobump service ([#1084](#1084)) ([968883e](968883e)) * **core:** database clients pooling improvements ([#1047](#1047)) ([8193cec](8193cec)) * **core:** swap out internal issuer for external issuer endpoint ([#1027](#1027)) ([c3828d0](c3828d0)) * **core:** update casbin policy to allow authorization service ([#1041](#1041)) ([552e970](552e970)) * **policy:** provide ns and val fqns back on list attributes response ([#1050](#1050)) ([1be04f6](1be04f6)), closes [#1052](#1052) * **policy:** rename unsafe rpcs for aligned casbin action determination ([#1067](#1067)) ([7861e4a](7861e4a)) * **policy:** run migrations on db only once for all policy services ([#1040](#1040)) ([db4f06f](db4f06f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #950