Skip to content

fix(policy): rename unsafe rpcs for aligned casbin action determination #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 2, 2024
Merged

fix(policy): rename unsafe rpcs for aligned casbin action determination #1067

merged 5 commits into from
Jul 2, 2024

Conversation

@jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented Jul 2, 2024 •
edited
Loading

5th PR for #115

Makes all RPC names on the unsafe services also start with Update to drive the casbin action definition matching logic: main/service/internal/auth/authn.go#L289-L290

Splitting out from #1066 due to the need to publish /protocol/go module dependency for consumption upstream in service and sdk modules.

@jakedoublev jakedoublev requested review from a team as code owners July 2, 2024 00:31
@jakedoublev jakedoublev enabled auto-merge July 2, 2024 00:39
ttschampel
ttschampel previously approved these changes Jul 2, 2024
View reviewed changes
@jakedoublev jakedoublev disabled auto-merge July 2, 2024 03:40
@jakedoublev jakedoublev enabled auto-merge July 2, 2024 03:40
jrschumacher
jrschumacher previously approved these changes Jul 2, 2024
View reviewed changes
@jrschumacher jrschumacher changed the title fix(policy): rename unsafe rpcs for aligned casbin action determination fix(policy)!: rename unsafe rpcs for aligned casbin action determination Jul 2, 2024
@jrschumacher jrschumacher changed the title fix(policy)!: rename unsafe rpcs for aligned casbin action determination fix(policy): rename unsafe rpcs for aligned casbin action determination Jul 2, 2024
@jakedoublev jakedoublev mentioned this pull request Jul 2, 2024
Closed
@dmihalcik-virtru
let buf breaking ignore unsafe.proto
46f54c6 
this is still in pre-alpha
@dmihalcik-virtru dmihalcik-virtru dismissed stale reviews from jrschumacher and ttschampel via 46f54c6 July 2, 2024 14:16
@jakedoublev jakedoublev added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 7861e4a Jul 2, 2024
@jakedoublev jakedoublev deleted the fix/unsafe-rpcs branch July 2, 2024 14:51
This was referenced Jul 2, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 2, 2024
@opentdf-automation
chore(main): release protocol/go 0.2.5 (#1065)
d55fdbd 
🤖 I have created a release *beep* *boop*
---


##
[0.2.5](protocol/go/v0.2.4...protocol/go/v0.2.5)
(2024-07-02)


### Features

* **policy:** add unsafe attribute RPC db connectivity
([#1022](#1022))
([fbc02f3](fbc02f3))


### Bug Fixes

* **policy:** rename unsafe rpcs for aligned casbin action determination
([#1067](#1067))
([7861e4a](7861e4a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Jul 2, 2024
@opentdf-automation
chore(main): release service 0.4.8 (#1028)
e3318e1 
🤖 I have created a release *beep* *boop*
---


##
[0.4.8](service/v0.4.7...service/v0.4.8)
(2024-07-02)


### Features

* **policy:** add index to fqn column in attribute_fqns table
([#1035](#1035))
([1b0cf38](1b0cf38)),
closes [#1053](#1053)
* **policy:** add unsafe attribute RPC db connectivity
([#1022](#1022))
([fbc02f3](fbc02f3))
* **policy:** attribute values unsafe actions db connectivity
([#1030](#1030))
([4a30426](4a30426))
* **policy:** register unsafe service in platform
([#1066](#1066))
([b7796cd](b7796cd))


### Bug Fixes

* **authz:** Return deny on GetDecision if resource attribute lookup
returns not found
([#962](#962))
([7dea640](7dea640))
* **core:** Autobump service
([#1072](#1072))
([409df67](409df67))
* **core:** Autobump service
([#1079](#1079))
([10138d2](10138d2))
* **core:** Autobump service
([#1084](#1084))
([968883e](968883e))
* **core:** database clients pooling improvements
([#1047](#1047))
([8193cec](8193cec))
* **core:** swap out internal issuer for external issuer endpoint
([#1027](#1027))
([c3828d0](c3828d0))
* **core:** update casbin policy to allow authorization service
([#1041](#1041))
([552e970](552e970))
* **policy:** provide ns and val fqns back on list attributes response
([#1050](#1050))
([1be04f6](1be04f6)),
closes [#1052](#1052)
* **policy:** rename unsafe rpcs for aligned casbin action determination
([#1067](#1067))
([7861e4a](7861e4a))
* **policy:** run migrations on db only once for all policy services
([#1040](#1040))
([db4f06f](db4f06f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
jakedoublev pushed a commit that referenced this pull request Jul 7, 2024
@opentdf-automation @jakedoublev
chore(main): release service 0.4.8 (#1028)
dfffc7a 
🤖 I have created a release *beep* *boop*
---


##
[0.4.8](service/v0.4.7...service/v0.4.8)
(2024-07-02)


### Features

* **policy:** add index to fqn column in attribute_fqns table
([#1035](#1035))
([1b0cf38](1b0cf38)),
closes [#1053](#1053)
* **policy:** add unsafe attribute RPC db connectivity
([#1022](#1022))
([fbc02f3](fbc02f3))
* **policy:** attribute values unsafe actions db connectivity
([#1030](#1030))
([4a30426](4a30426))
* **policy:** register unsafe service in platform
([#1066](#1066))
([b7796cd](b7796cd))


### Bug Fixes

* **authz:** Return deny on GetDecision if resource attribute lookup
returns not found
([#962](#962))
([7dea640](7dea640))
* **core:** Autobump service
([#1072](#1072))
([409df67](409df67))
* **core:** Autobump service
([#1079](#1079))
([10138d2](10138d2))
* **core:** Autobump service
([#1084](#1084))
([968883e](968883e))
* **core:** database clients pooling improvements
([#1047](#1047))
([8193cec](8193cec))
* **core:** swap out internal issuer for external issuer endpoint
([#1027](#1027))
([c3828d0](c3828d0))
* **core:** update casbin policy to allow authorization service
([#1041](#1041))
([552e970](552e970))
* **policy:** provide ns and val fqns back on list attributes response
([#1050](#1050))
([1be04f6](1be04f6)),
closes [#1052](#1052)
* **policy:** rename unsafe rpcs for aligned casbin action determination
([#1067](#1067))
([7861e4a](7861e4a))
* **policy:** run migrations on db only once for all policy services
([#1040](#1040))
([db4f06f](db4f06f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttschampel ttschampel ttschampel approved these changes

@pflynn-virtru pflynn-virtru pflynn-virtru approved these changes

@jrschumacher jrschumacher jrschumacher left review comments

@dmihalcik-virtru dmihalcik-virtru Awaiting requested review from dmihalcik-virtru

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jakedoublev @jrschumacher @ttschampel @pflynn-virtru @dmihalcik-virtru