Skip to content

fix(authz): Return deny on GetDecision if resource attribute lookup returns not found #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2024
Merged

fix(authz): Return deny on GetDecision if resource attribute lookup returns not found #962

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
605f202
return deny decision if attribute lookup returns not found
elizabethhealy Jun 11, 2024
07771f5
remove log statement
elizabethhealy Jun 11, 2024
ba1cf89
check for status instead of string
elizabethhealy Jun 25, 2024
4c81936
Merge branch 'main' into decision-deny-attr-dne
elizabethhealy Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion service/authorization/authorization.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,28 @@ func (as *AuthorizationService) GetDecisions(ctx context.Context, req *authoriza
// get attribute definition/value combinations
dataAttrDefsAndVals, err := retrieveAttributeDefinitions(ctx, ra, as.sdk)
if err != nil {
// TODO: should all decisions in a request fail if one FQN lookup fails?
// if attribute an FQN does not exist
// return deny for all entity chains aginst this RA set and continue to next
if strings.Contains(err.Error(), db.ErrTextNotFound) {
for _, ec := range dr.GetEntityChains() {
decisionResp := &authorization.DecisionResponse{
Decision: authorization.DecisionResponse_DECISION_DENY,
EntityChainId: ec.GetId(),
Action: &policy.Action{
Value: &policy.Action_Standard{
Standard: policy.Action_STANDARD_ACTION_TRANSMIT,
},
},
}
if ra.GetResourceAttributesId() != "" {
decisionResp.ResourceAttributesId = ra.GetResourceAttributesId()
} else if len(ra.GetAttributeValueFqns()) > 0 {
decisionResp.ResourceAttributesId = ra.GetAttributeValueFqns()[0]
}
rsp.DecisionResponses = append(rsp.DecisionResponses, decisionResp)
}
continue
}
return nil, db.StatusifyError(err, db.ErrTextGetRetrievalFailed, slog.String("fqns", strings.Join(ra.GetAttributeValueFqns(), ", ")))
}
var attrDefs []*policy.Attribute
Expand Down