OCPBUGS-61521: gather-extra: Fix oc get for config-resources.json #69141
Conversation
Fix a syntax error in the command to get config-resources.json.
Before this commit, gather-extra-commands.sh produced an empty
config-resources.json file and the following error messages:
Error from server (NotFound): apiservers.config.openshift.io "authentication.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "build.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "console.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "dns.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "featuregate.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "image.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "infrastructure.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "ingress.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "network.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "oauth.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "project.config.openshift.io" not found
Error from server (NotFound): apiservers.config.openshift.io "scheduler.config.openshift.io" not found
These errors are caused by missing commas, which cause the oc get
command to treat the resource names listed after the apiservers resource
as object names under the apiservers resource.
This commit adds the missing commas, so that the oc get command gets the
listed resources and store them in config-resources.json.
This commit fixes OCPBUGS-61521.
https://issues.redhat.com/browse/OCPBUGS-61521
Follow-up to commit 23ca2ce.
ci-operator/step-registry/gather/extra/gather-extra-commands.sh: Add
missing commas in the oc get command for config-resources.json
openshift-ci-robot
added
jira/severity-moderate
|
@Miciah: This pull request references Jira Issue OCPBUGS-61521, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@Miciah: This pull request references Jira Issue OCPBUGS-61521, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator |
|
@Miciah: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator |
|
@Miciah: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/69141/rehearse-69141-pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator/1966146330942246912 has the expected results:
|
|
@dgoodwin, this is a simple change to fix some consistent errors in gather-extra. Do you or our team have capacity to review it? |
|
@vrutkovs, can you review this PR please? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/pj-rehearse ack |
|
@Miciah: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
openshift-merge-bot
bot
merged commit 31b2102
into
openshift:master
|
@Miciah: Jira Issue OCPBUGS-61521: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-61521 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
Fix a syntax error in the command to get
config-resources.json.Before this commit,
gather-extra-commands.shproduced an emptyconfig-resources.jsonfile and the following error messages:These errors are caused by missing commas, which cause the
oc getcommand to treat the resource names listed after the apiservers resource as object names under the apiservers resource.This commit adds the missing commas, so that the
oc getcommand gets the listed resources and store them inconfig-resources.json.Follow-up to #5962.