Skip to content

OSASINFRA-3612: OpenStack: Use csi-operator jobs to build and test manila CSI #56882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Sep 26, 2024
Merged

OSASINFRA-3612: OpenStack: Use csi-operator jobs to build and test manila CSI #56882

openshift-merge-bot merged 1 commit into from
Sep 26, 2024

Conversation

@MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Sep 18, 2024 •
edited
Loading

As part of the process to migrate the manila CSI operator into the csi-operator, this PR moves the images built to be based on the legacy folder under csi-operator.

here is the PR for shipping the image from the new operator openshift-eng/ocp-build-data#5403

depends on openshift/csi-operator#280

@MaysaMacedo MaysaMacedo changed the title OpenStack: Use csi-operator jobs to build and test manila CSI OSASINFRA-3612: OpenStack: Use csi-operator jobs to build and test manila CSI Sep 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2024 •
edited by openshift-ci bot
Loading

@MaysaMacedo: This pull request references OSASINFRA-3612 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 18, 2024 •
edited by openshift-ci bot
Loading

@MaysaMacedo: This pull request references OSASINFRA-3612 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

As part of the process to migrate the manila CSI operator into the csi-operator, this PR moves the images built to be based on the legacy folder under csi-operator.

depends on openshift/csi-operator#280

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 18, 2024

/hold

until dependent PR is merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2024
mandre
mandre reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase after #56812 has merged.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 20, 2024

@MaysaMacedo, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: duplicated presubmit jobs (consider both inrepo and central config): [pull-ci-openshift-csi-operator-master-e2e-openstack pull-ci-openshift-csi-operator-release-4.18-e2e-openstack pull-ci-openshift-csi-operator-release-4.19-e2e-openstack]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 23, 2024

/test openshift-image-mirror-mappings

mandre
mandre reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
@mandre
Copy link
Member

mandre commented Sep 25, 2024

/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-openstack-manila-csi

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 25, 2024

@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mandre
Copy link
Member

mandre commented Sep 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@mandre
Copy link
Member

mandre commented Sep 25, 2024

/assign gnufied

@MaysaMacedo MaysaMacedo mentioned this pull request Sep 25, 2024
Merged
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 25, 2024

/hold cancel

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 25, 2024

/pj-rehearse pull-ci-openshift-csi-driver-manila-operator-release-4.17-e2e-openstack-csi

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 25, 2024

@MaysaMacedo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 25, 2024 •
edited by openshift-ci bot
Loading

@MaysaMacedo: This pull request references OSASINFRA-3612 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

As part of the process to migrate the manila CSI operator into the csi-operator, this PR moves the images built to be based on the legacy folder under csi-operator.

here is the PR for shipping the image from the new operator openshift-eng/ocp-build-data#5403

depends on openshift/csi-operator#280

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@gnufied
Copy link
Member

gnufied commented Sep 25, 2024

/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-openstack-manila-csi

@gnufied
Copy link
Member

gnufied commented Sep 25, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 25, 2024

@gnufied: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 25, 2024

@gnufied: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 25, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2024

[REHEARSALNOTIFIER]
@MaysaMacedo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-driver-manila-operator-release-4.17-e2e-openstack-csi openshift/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-manila-operator-release-4.16-e2e-openstack-csi openshift/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-manila-operator-release-4.15-e2e-openstack-csi openshift/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-manila-operator-release-4.14-e2e-openstack-csi openshift/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-manila-operator-release-4.13-e2e-openstack-csi openshift/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-manila-operator-release-4.12-e2e-openstack-csi openshift/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-manila-operator-release-4.11-e2e-openstack-csi openshift/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-manila-operator-release-4.10-e2e-openstack-csi openshift/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-manila-operator-release-4.9-e2e-openstack-csi openshift/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-master-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.19-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.18-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.17-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.16-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.15-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.14-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.13-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.12-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.11-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.10-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-csi-driver-nfs-release-4.9-e2e-openstack-csi openshift/csi-driver-nfs presubmit Registry content changed
pull-ci-openshift-kubernetes-master-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.19-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.18-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed
pull-ci-openshift-kubernetes-release-4.17-e2e-openstack-csi-manila openshift/kubernetes presubmit Registry content changed

A total of 137 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

mandre
mandre reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@gnufied
Copy link
Member

gnufied commented Sep 26, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, mandre, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 26, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2024

@MaysaMacedo: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 26, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

@MaysaMacedo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/csi-operator/master/e2e-openstack-manila-csi 9ed7edb link unknown /pj-rehearse pull-ci-openshift-csi-operator-master-e2e-openstack-manila-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a10b9ff into openshift:master Sep 26, 2024
@openshift-merge-bot openshift-merge-bot bot deleted the move-manila-csi-jobs branch September 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@jsafrane jsafrane Awaiting requested review from jsafrane

2 more reviewers

@gnufied gnufied gnufied left review comments

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gnufied gnufied

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MaysaMacedo @openshift-ci-robot @mandre @gnufied @openshift-merge-robot