OSASINFRA-3609: Use csi-operator for building openstack-cinder CSI driver #56812
Conversation
stephenfin
force-pushed
the
OSASINFRA-3608
branch
from
fae6fbb to
111133a
Compare
openshift-merge-robot
added
the
needs-rebase
stephenfin
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@stephenfin: This pull request references OSASINFRA-3609 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
removed
the
needs-rebase
We are in the process of migrating everything across to csi-operator. See [1] and [2] for more context. This is based on same note from aws-ebs-csi-driver-operator repo. [1]: openshift/csi-operator#278 [2]: openshift/release#56812 Signed-off-by: Stephen Finucane <[email protected]>
|
Depends on openshift/csi-operator#278 |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
We shouldn't merge before openshift/csi-operator#278 lands. LGTM otherwise
| env: | ||
| TEST_SCENARIOS: \[CSI-Driver\]|\[Azure-File-CSI-Driver\]|\[Azure-File-CSI-Driver-Operator\] | ||
| workflow: openshift-e2e-azure-csi-extended | ||
| - as: e2e-openstack-cinder |
There was a problem hiding this comment.
I know we're just porting whatever was in the cinder-csi-driver-operator repo, but What's this value of this job, if we have another one that runs CSI specific tests?
There was a problem hiding this comment.
that's possibly to ensure that the operator respects the openshift requirements for their operators, but perhaps that should be part of the suite we run in the openshift-e2e-openstack-csi-cinder workflow.
There was a problem hiding this comment.
How is this job different from e2e-openstack-cinder-csi ?
There was a problem hiding this comment.
it should be just e2e-openstack.
There was a problem hiding this comment.
I renamed the job but kept it for now. Let's determine whether we want to keep it long-term post-merge?
There was a problem hiding this comment.
All components that are installed by default should run regular e2e test to make sure that a CSI driver update does not break other functionality of the cluster, dunno... Routes or Networking. The probability is IMO very small here.
And the same for upgrades - all components that are installed by default should run regular e2e-upgrade job to ensure a CSI driver change does not break upgrade. That's much more likely to happen, we had cases when a driver upgrade broke an existing cluster.
These rules were documented somewhere, but I can't find it now :-(
|
@stephenfin: This pull request references OSASINFRA-3609 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ci-operator/config/openshift/csi-operator/openshift-csi-operator-master.yaml
Outdated
Show resolved
Hide resolved
stephenfin
force-pushed
the
OSASINFRA-3608
branch
4 times, most recently
from
3cfd3b7 to
813ada5
Compare
| TEST_SUITE: experimental/reliability/minimal | ||
| workflow: openshift-e2e-openstack-ipi | ||
| - as: e2e-openstack-cinder-csi | ||
| run_if_changed: ^(Dockerfile\.openstack-cinder|legacy/openstack-cinder-csi-driver-operator/.*) |
There was a problem hiding this comment.
nice. this would be useful for other operators too!
There was a problem hiding this comment.
It may need to be a bit more involved, since conceivably any chance to the "common" code could affect an individual driver. However, we could just rely on the fact that (a) changes to the asset generation will require an asset generation run (I assume there's a job to check that - I have yet to look) and (b) if it's a programming error the build will likely fail. In any case, a can to kick down the road slightly until we start reworking this driver to take advantage of the generator.
stephenfin
force-pushed
the
OSASINFRA-3608
branch
from
813ada5 to
48ebb50
Compare
|
/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-openstack pull-ci-openshift-csi-operator-master-e2e-openstack-cinder-csi pull-ci-openshift-csi-operator-release-4.18-e2e-openstack pull-ci-openshift-csi-operator-release-4.18-e2e-openstack-cinder-csi pull-ci-openshift-csi-operator-release-4.19-e2e-openstack pull-ci-openshift-csi-operator-release-4.19-e2e-openstack-cinder-csi |
|
@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Make it more obvious what goes where. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
Using the current legacy package layout. A future change will expand this to cover the future package layout. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
OSASINFRA-3608
branch
from
48ebb50 to
a81fc34
Compare
|
[REHEARSALNOTIFIER]
A total of 124 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-csi-operator-master-e2e-openstack-cinder-csi |
|
@mandre: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
This is looking good. There are failures but the actual deployment happened as expected (which is the important bit) |
|
/pj-rehearse ack |
|
@stephenfin: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, mandre, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@stephenfin: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
7 participants
openshift/openstack-cinder-csi-driver-operator#180 will mark the old location as obsolete.
openshift-eng/ocp-build-data#5402 will ensure we ship containers from this location.