Skip to content

OSASINFRA-3611: Add legacy csi-driver-manila-operator #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Sep 25, 2024
Merged

OSASINFRA-3611: Add legacy csi-driver-manila-operator #280

openshift-merge-bot merged 3 commits into from
Sep 25, 2024

Conversation

@MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Sep 18, 2024

  • This PR moves the csi-driver-manila-operator into the legacy folder with the following command:
$ git remote add ocp git@github.com:openshift/csi-driver-manila-operator.git
$ git subtree add --prefix legacy/csi-driver-manila-operator ocp master --squash
  • Adds the Dockerfile for building the operator image from new location

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2024 •
edited by openshift-ci bot
Loading

@MaysaMacedo: This pull request references OSASINFRA-3611 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

  • This PR moves the csi-driver-manila-operator into the legacy folder with the following command:
$ git remote add ocp git@github.com:openshift/csi-driver-manila-operator.git
$ git subtree add --prefix legacy/csi-driver-manila-operator ocp master --squash
  • Adds the Dockerfile for building the operator image from new location

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@MaysaMacedo MaysaMacedo marked this pull request as ready for review September 18, 2024 14:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana September 18, 2024 14:43
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 18, 2024
This was referenced Sep 18, 2024
Merged
Merged
Merged
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 19, 2024

/verify-owners

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 19, 2024

/verify-owners

1 similar comment
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 19, 2024

/verify-owners

@MaysaMacedo
Squashed 'legacy/csi-driver-manila-operator/' content from commit f44…
eed6bbc 
…d5ecdd

git-subtree-dir: legacy/csi-driver-manila-operator
git-subtree-split: f44d5ecddb5c695979627317b98736072f5440ee
@MaysaMacedo
Merge commit 'eed6bbc33a9c771f2fef6671a3d1d595fb5a94aa' as 'legacy/cs…
8fd241e 
…i-driver-manila-operator'
@MaysaMacedo
Build openstack-manila CSI image from legacy folder
aca3c49
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 20, 2024
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 20, 2024

/cc @mandre

@openshift-ci openshift-ci bot requested a review from mandre September 20, 2024 11:11
stephenfin
stephenfin reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Merge is based on current HEAD of master, f44d5ecddb5c6 ✔️
  • Dockerfile.openstack-manila looks sane ✔️

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
mandre
mandre reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gnufied
Copy link
Member

gnufied commented Sep 20, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@eurijon
Copy link

eurijon commented Sep 23, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@MaysaMacedo: This pull request references OSASINFRA-3611 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

Details

In response to this:

  • This PR moves the csi-driver-manila-operator into the legacy folder with the following command:
$ git remote add ocp git@github.com:openshift/csi-driver-manila-operator.git
$ git subtree add --prefix legacy/csi-driver-manila-operator ocp master --squash
  • Adds the Dockerfile for building the operator image from new location

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gnufied
Copy link
Member

gnufied commented Sep 23, 2024

/lgtm
/approve

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 23, 2024

@gnufied could you also check the docs-approved and px-approved labels?

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 23, 2024

/retest

@gnufied
Copy link
Member

gnufied commented Sep 23, 2024

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Sep 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, MaysaMacedo, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024

/retest-required

Remaining retests: 0 against base HEAD b0e0e27 and 2 for PR HEAD aca3c49 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2024

/retest-required

Remaining retests: 0 against base HEAD 35dea4e and 1 for PR HEAD aca3c49 in total

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 24, 2024

/test hypershift-aws-e2e-external

1 similar comment
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 24, 2024

/test hypershift-aws-e2e-external

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2024

/retest-required

Remaining retests: 0 against base HEAD 35dea4e and 2 for PR HEAD aca3c49 in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 24, 2024

/retest-required

Remaining retests: 0 against base HEAD 35dea4e and 2 for PR HEAD aca3c49 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2024 •
edited
Loading

@MaysaMacedo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi aca3c49 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Sep 25, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit a157adc into openshift:master Sep 25, 2024
@openshift-bot
Copy link

openshift-bot commented Sep 25, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-disk-csi-driver-operator
This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.18.0-202409250540.p0.ga157adc.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 25, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-efs-csi-driver-operator
This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.18.0-202409250540.p0.ga157adc.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 25, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-ebs-csi-driver-operator
This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.18.0-202409250540.p0.ga157adc.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 25, 2024

[ART PR BUILD NOTIFIER]

Distgit: azure-file-csi-driver-operator
This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.18.0-202409250540.p0.ga157adc.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 25, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-smb-csi-driver-operator
This PR has been included in build ose-smb-csi-driver-operator-container-v4.18.0-202409250540.p0.ga157adc.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 25, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-openstack-cinder-csi-driver-operator
This PR has been included in build ose-openstack-cinder-csi-driver-operator-container-v4.18.0-202409250540.p0.ga157adc.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Sep 26, 2024

[ART PR BUILD NOTIFIER]

Distgit: csi-driver-manila-operator
This PR has been included in build csi-driver-manila-operator-container-v4.18.0-202409261540.p0.ga157adc.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@tsmetana tsmetana Awaiting requested review from tsmetana

2 more reviewers

@mandre mandre mandre left review comments

@stephenfin stephenfin stephenfin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gnufied gnufied

@mandre mandre

@stephenfin stephenfin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MaysaMacedo @openshift-ci-robot @gnufied @eurijon @openshift-bot @mandre @stephenfin