Skip to content

OSASINFRA-3613: OpenStack: ship manila CSI operator from csi-operator #5403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Sep 26, 2024
Merged

OSASINFRA-3613: OpenStack: ship manila CSI operator from csi-operator #5403

openshift-merge-bot merged 1 commit into from
Sep 26, 2024

Conversation

@MaysaMacedo
Copy link

@MaysaMacedo MaysaMacedo commented Sep 18, 2024 •
edited
Loading

We have moved the content of csi-driver-manila-operator repo to csi-operator repo and are in the progress of migrating our jobs. This is the final step of the process.

Here is the similar process that was done for cinder csi #5402

@MaysaMacedo MaysaMacedo changed the title OpenStack: ship manila CSI operator from csi-operator OSASINFRA-3610: OpenStack: ship manila CSI operator from csi-operator Sep 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2024 •
edited by openshift-ci bot
Loading

@MaysaMacedo: This pull request references OSASINFRA-3610 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo
Copy link
Author

MaysaMacedo commented Sep 18, 2024

/hold

Depends on openshift/csi-operator#280

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2024
mandre
mandre reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@mandre: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 25, 2024 •
edited by openshift-ci bot
Loading

@MaysaMacedo: This pull request references OSASINFRA-3610 which is a valid jira issue.

Details

In response to this:

We have moved the content of csi-driver-manila-operator repo to csi-operator repo and are in the progress of migrating our jobs. This is the final step of the process.

Here is the similar process that was done for cinder csi #5402

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@MaysaMacedo MaysaMacedo mentioned this pull request Sep 25, 2024
Merged
joepvd
joepvd reviewed Sep 26, 2024
View reviewed changes
@MaysaMacedo MaysaMacedo force-pushed the ship-manila-new-location branch from 29dfb91 to f88a848 Compare September 26, 2024 12:41
@MaysaMacedo
Copy link
Author

MaysaMacedo commented Sep 26, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@MaysaMacedo
Copy link
Author

MaysaMacedo commented Sep 26, 2024

@joepvd Thanks for the review. Can you take another look?
This PR is getting merged openshift/release#56882

@MaysaMacedo
Copy link
Author

MaysaMacedo commented Sep 26, 2024

/assign @joepvd
/assign @ashwindasr

@ashwindasr
Copy link
Contributor

ashwindasr commented Sep 26, 2024 •
edited
Loading

/hold

Until test build passes: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=64561380

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
ashwindasr
ashwindasr approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ashwindasr ashwindasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks good

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@ashwindasr
Copy link
Contributor

ashwindasr commented Sep 26, 2024 •
edited
Loading

/unhold

build green

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 312ac51 into openshift-eng:openshift-4.18 Sep 26, 2024
@MaysaMacedo MaysaMacedo deleted the ship-manila-new-location branch September 26, 2024 15:15
@MaysaMacedo MaysaMacedo changed the title OSASINFRA-3610: OpenStack: ship manila CSI operator from csi-operator OSASINFRA-3613: OpenStack: ship manila CSI operator from csi-operator Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joepvd joepvd joepvd left review comments

@ashwindasr ashwindasr ashwindasr approved these changes

+1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joepvd joepvd

@ashwindasr ashwindasr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MaysaMacedo @openshift-ci-robot @ashwindasr @mandre @joepvd