Skip to content

OSASINFRA-3618: Add Cinder CSI support (part 3) #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 12, 2024
Merged

OSASINFRA-3618: Add Cinder CSI support (part 3) #298

openshift-merge-bot merged 1 commit into from
Nov 12, 2024

Conversation

@stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Oct 15, 2024 •
edited
Loading

This is part 3 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR addresses the final step in the migration guide, namely removing code from vendor/legacy in this repository.

Previous steps:

@stephenfin
openstack-cinder: Remove legacy operator code
8a95ac0 
This is no longer used or referenced anywhere. Drop it:

  git rm -r legacy/openstack-cinder-csi-driver-operator

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

Details

In response to this:

This is part 2 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR addresses the final step in the [migration guide][migration], namely removing code from vendor/legacy in this repository.

Previous steps:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 15, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

Details

In response to this:

This is part 3 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR addresses the final step in the migration guide, namely removing code from vendor/legacy in this repository.

Previous steps:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 15, 2024

/cc @mandre
/cc @gnufied

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
mandre
mandre reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2024
@stephenfin stephenfin mentioned this pull request Oct 17, 2024
Merged
@stephenfin
Copy link
Contributor Author

stephenfin commented Oct 18, 2024

/retest-required

@gnufied
Copy link
Member

gnufied commented Nov 6, 2024

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Nov 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2024 •
edited by openshift-ci bot
Loading

@stephenfin: This pull request references OSASINFRA-3618 which is a valid jira issue.

Details

In response to this:

This is part 3 of the process of merging the OpenStack Cinder CSI Driver operator into csi-operator.

This PR addresses the final step in the migration guide, namely removing code from vendor/legacy in this repository.

Previous steps:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2024

/retest-required

Remaining retests: 0 against base HEAD 767a674 and 2 for PR HEAD 8a95ac0 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2024

/retest-required

Remaining retests: 0 against base HEAD ad8805a and 1 for PR HEAD 8a95ac0 in total

@stephenfin
Copy link
Contributor Author

stephenfin commented Nov 7, 2024

/retest-required

@stephenfin
Copy link
Contributor Author

stephenfin commented Nov 7, 2024 •
edited
Loading

Okay, no point retesting actually. Our CI job needs to be updated first. @MaysaMacedo has proposed this via openshift/release#58561 and openshift/csi-operator#316.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2024

/retest-required

Remaining retests: 0 against base HEAD 79d363e and 2 for PR HEAD 8a95ac0 in total

2 similar comments
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024

/retest-required

Remaining retests: 0 against base HEAD 79d363e and 2 for PR HEAD 8a95ac0 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024

/retest-required

Remaining retests: 0 against base HEAD 79d363e and 2 for PR HEAD 8a95ac0 in total

@stephenfin
Copy link
Contributor Author

stephenfin commented Nov 11, 2024

Okay, no point retesting actually. Our CI job needs to be updated first. @MaysaMacedo has proposed this via openshift/release#58561 and openshift/csi-operator#316.

There are merged now

@stephenfin
Copy link
Contributor Author

stephenfin commented Nov 11, 2024

/test e2e-openstack-manila-csi

@MaysaMacedo
Copy link
Contributor

MaysaMacedo commented Nov 11, 2024 •
edited
Loading

@gnufied
The manila-csi shouldn't be running in this PR as it doesn't fulfill the run_if_changed requirement and it doesn't touch anything related to manila. I have reached out to the ocp-testplatform to understand why this is happening. While I don't hear back from them, can you consider overriding the manila-csi job? Another option is to make the job optional.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2024

/retest-required

Remaining retests: 0 against base HEAD 79d363e and 2 for PR HEAD 8a95ac0 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024 •
edited
Loading

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 8a95ac0 link false /test security
ci/prow/e2e-azurestack-csi 8a95ac0 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gnufied
Copy link
Member

gnufied commented Nov 12, 2024

/test hypershift-aws-e2e-external

@openshift-merge-bot openshift-merge-bot bot merged commit ee0638d into openshift:master Nov 12, 2024
@openshift-bot
Copy link

openshift-bot commented Nov 12, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-ebs-csi-driver-operator
This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.18.0-202411121041.p0.gee0638d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Nov 12, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-disk-csi-driver-operator
This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.19.0-202411121041.p0.gee0638d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Nov 12, 2024

[ART PR BUILD NOTIFIER]

Distgit: azure-file-csi-driver-operator
This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.19.0-202411121041.p0.gee0638d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Nov 12, 2024

[ART PR BUILD NOTIFIER]

Distgit: csi-driver-manila-operator
This PR has been included in build csi-driver-manila-operator-container-v4.19.0-202411121041.p0.gee0638d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Nov 12, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-efs-csi-driver-operator
This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.19.0-202411121041.p0.gee0638d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Nov 12, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-efs-csi-driver-operator
This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.18.0-202411121041.p0.gee0638d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Nov 12, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-openstack-cinder-csi-driver-operator
This PR has been included in build ose-openstack-cinder-csi-driver-operator-container-v4.18.0-202411121041.p0.gee0638d.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented Nov 12, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-smb-csi-driver-operator
This PR has been included in build ose-smb-csi-driver-operator-container-v4.18.0-202411121041.p0.gee0638d.assembly.stream.el9.
All builds following this will include this PR.

@stephenfin stephenfin deleted the add-cinder-csi-step3 branch November 13, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@mdbooth mdbooth Awaiting requested review from mdbooth

1 more reviewer

@mandre mandre mandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stephenfin @openshift-ci-robot @gnufied @MaysaMacedo @openshift-bot @mandre