-
Notifications
You must be signed in to change notification settings - Fork 49
NO-JIRA: Move doc on migrating CSI Driver in-tree #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Move doc on migrating CSI Driver in-tree #279
Conversation
It makes more sense for this to live locally. This is copied unchanged for now. Future changes will make further changes. Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
|
I am personally fine with this. @openshift/team-storage-committers what do you think? |
|
Wrong team cc @openshift-team-storage |
|
/lgtm |
|
/lgtm |
|
/override ci/prow/e2e-aws-ovn-upgrade |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gnufied: Overrode contexts on behalf of gnufied: ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@stephenfin can you check failing cinder-csi tests. If they are going to block further merges into csi-operator repo, it may be worth making them optional. |
|
/override ci/prow/e2e-openstack-cinder-csi |
|
@stephenfin: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gnufied: Overrode contexts on behalf of gnufied: ci/prow/e2e-openstack-cinder-csi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/override ci/prow/hypershift-aws-e2e-external |
|
@gnufied: Overrode contexts on behalf of gnufied: ci/prow/hypershift-aws-e2e-external DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@stephenfin: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-azure-disk-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-efs-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-smb-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-ebs-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: azure-file-csi-driver-operator |
|
[ART PR BUILD NOTIFIER] Distgit: ose-openstack-cinder-csi-driver-operator |
@gnufied I'm not sure why this is running. Per this line from openshift/release#56812: run_if_changed: ^(Dockerfile\.openstack-cinder|legacy/openstack-cinder-csi-driver-operator/.*)...that job should only be running if either |
|
@stephenfin I think there was a way to test this stuff. Can you please file a bug for this? I wonder if those path sepatrors needs to be escaped. This is going to be an issue in merging stuff into |
This is far more discoverable and it allows us to iterate of the procedure faster. The enhancement will be updated to reference this new doc.