Skip to content

Conversation

@stephenfin
Copy link
Contributor

This is far more discoverable and it allows us to iterate of the procedure faster. The enhancement will be updated to reference this new doc.

It makes more sense for this to live locally. This is copied unchanged
for now. Future changes will make further changes.

Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
@gnufied
Copy link
Member

gnufied commented Sep 18, 2024

I am personally fine with this. @openshift/team-storage-committers what do you think?

@gnufied
Copy link
Member

gnufied commented Sep 18, 2024

Wrong team cc @openshift-team-storage

@gnufied
Copy link
Member

gnufied commented Sep 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
@gnufied
Copy link
Member

gnufied commented Sep 20, 2024

/lgtm
/approve
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Sep 20, 2024
@gnufied
Copy link
Member

gnufied commented Sep 20, 2024

/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-csi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@gnufied: Overrode contexts on behalf of gnufied: ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-aws-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gnufied
Copy link
Member

gnufied commented Sep 20, 2024

/retest

@gnufied
Copy link
Member

gnufied commented Sep 21, 2024

@stephenfin can you check failing cinder-csi tests. If they are going to block further merges into csi-operator repo, it may be worth making them optional.

@gnufied
Copy link
Member

gnufied commented Sep 23, 2024

/override ci/prow/e2e-openstack-cinder-csi

@gnufied gnufied changed the title Move doc on migrating CSI Driver in-tree NO-JIRA: Move doc on migrating CSI Driver in-tree Sep 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci-robot
Copy link

@stephenfin: This pull request explicitly references no jira issue.

Details

In response to this:

This is far more discoverable and it allows us to iterate of the procedure faster. The enhancement will be updated to reference this new doc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@gnufied: Overrode contexts on behalf of gnufied: ci/prow/e2e-openstack-cinder-csi

Details

In response to this:

/override ci/prow/e2e-openstack-cinder-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gnufied
Copy link
Member

gnufied commented Sep 23, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3bb5709 and 2 for PR HEAD 6bb02c7 in total

@gnufied
Copy link
Member

gnufied commented Sep 23, 2024

/override ci/prow/hypershift-aws-e2e-external

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@gnufied: Overrode contexts on behalf of gnufied: ci/prow/hypershift-aws-e2e-external

Details

In response to this:

/override ci/prow/hypershift-aws-e2e-external

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@stephenfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi 6bb02c7 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 35dea4e into openshift:master Sep 23, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-azure-disk-csi-driver-operator
This PR has been included in build ose-azure-disk-csi-driver-operator-container-v4.18.0-202409240038.p0.g35dea4e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-efs-csi-driver-operator
This PR has been included in build ose-aws-efs-csi-driver-operator-container-v4.18.0-202409240038.p0.g35dea4e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-smb-csi-driver-operator
This PR has been included in build ose-smb-csi-driver-operator-container-v4.18.0-202409240038.p0.g35dea4e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-ebs-csi-driver-operator
This PR has been included in build ose-aws-ebs-csi-driver-operator-container-v4.18.0-202409240038.p0.g35dea4e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: azure-file-csi-driver-operator
This PR has been included in build ose-azure-file-csi-driver-operator-container-v4.18.0-202409240038.p0.g35dea4e.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-openstack-cinder-csi-driver-operator
This PR has been included in build ose-openstack-cinder-csi-driver-operator-container-v4.18.0-202409240038.p0.g35dea4e.assembly.stream.el9.
All builds following this will include this PR.

@stephenfin stephenfin deleted the docs-adding-a-new-driver branch September 24, 2024 11:48
@stephenfin
Copy link
Contributor Author

stephenfin commented Sep 24, 2024

@stephenfin can you check failing cinder-csi tests. If they are going to block further merges into csi-operator repo, it may be worth making them optional.

@gnufied I'm not sure why this is running. Per this line from openshift/release#56812:

run_if_changed: ^(Dockerfile\.openstack-cinder|legacy/openstack-cinder-csi-driver-operator/.*)

...that job should only be running if either Dockerfile.openstack-cinder or something in legacy/openstack-cinder-csi-driver-operator changed. Right? I wonder what I've missed...

@gnufied
Copy link
Member

gnufied commented Sep 25, 2024

@stephenfin I think there was a way to test this stuff. Can you please file a bug for this? I wonder if those path sepatrors needs to be escaped. This is going to be an issue in merging stuff into csi-operator if this remains broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants