WRKLDS-1251: Remove temporarily must-gather-base image from oc presubmits

[ardaguclu]

must-gather base image is overridden by the latest version of cli image in oc presubmits jobs due to this configuration. However, since we are trying to change the base image of oc to RHEL9 openshift/oc#1752 and must-gather is still on RHEL8 (oc.rhel9 does not work on RHEL8 hosts), we have to disable this override temporarily. Because we are explicitly stating to must-gather that is to use oc.rhel8 in openshift/must-gather#418 and openshift/must-gather#420.

this PR has to be reverted back;

• immediately, if this does not solve the problem.
• until must-gather is based on RHEL9, if this solves the problem.

[openshift-ci-robot]

@ardaguclu: This pull request references WRKLDS-1251 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

must-gather base image is overridden by the latest version of cli image in oc presubmits jobs due to this configuration. However, since we are trying to change the base image of oc to RHEL9 openshift/oc#1752 and must-gather is still on RHEL8 (oc.rhel9 does not work on RHEL8 hosts), we have to disable this override temporarily. Because we are explicitly stating to must-gather that is to use oc.rhel8 in openshift/must-gather#418 and openshift/must-gather#420.

this PR has to be reverted back;

• immediately, if this does not solve the problem.
• until must-gather is based on RHEL9, if this solves the problem.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@ardaguclu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-oc-release-4.16-build-rpms-from-tar	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-e2e-agnostic-ovn-cmd	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-e2e-aws-certrotation	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-e2e-aws-ovn	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-e2e-aws-ovn-builds	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-e2e-aws-ovn-serial	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-e2e-aws-ovn-upgrade	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-e2e-metal-ipi-ovn-ipv6	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-images	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-rpm-build	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-security	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-unit	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-verify	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.16-verify-deps	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-build-rpms-from-tar	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-e2e-agnostic-ovn-cmd	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-e2e-aws-certrotation	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-e2e-aws-ovn	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-e2e-aws-ovn-builds	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-e2e-aws-ovn-serial	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-e2e-aws-ovn-upgrade	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-e2e-metal-ipi-ovn-ipv6	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-images	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-rpm-build	openshift/oc	presubmit	Ci-operator config changed
pull-ci-openshift-oc-release-4.17-security	openshift/oc	presubmit	Ci-operator config changed

A total of 43 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[ardaguclu]

/pj-rehearse pull-ci-openshift-oc-release-4.16-images
/pj-rehearse pull-ci-openshift-oc-release-4.16-e2e-agnostic-ovn-cmd
/pj-rehearse pull-ci-openshift-oc-release-4.16-e2e-aws-ovn

[openshift-ci-robot]

@ardaguclu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

@ardaguclu: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

[openshift-ci-robot]

@ardaguclu: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

[ardaguclu]

/pj-rehearse pull-ci-openshift-oc-release-4.16-e2e-agnostic-ovn-cmd pull-ci-openshift-oc-release-4.16-e2e-aws-ovn

[openshift-ci-robot]

@ardaguclu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[ingvagabund]

Worth trying
/lgtm
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/oc/OWNERS [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ardaguclu]

/hold cancel

[ardaguclu]

I've verified that the must-gather imagestreamtag in CI system hasn't been overridden by cli image.
podman inspect's last log shows that the explicit oc is copied which is the desired behavior;

{
                    "created": "2024-04-30T10:58:28.653907512Z",
                    "created_by": "/bin/sh -c #(nop) COPY file:9168d0731e1fa0d6e24ea3fd1b9300dbeeaac1b420df3511af366adde8fbead5 in /usr/bin/oc ",
                    "empty_layer": true
               },

[ardaguclu]

Failure of https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/51578/rehearse-51578-pull-ci-openshift-oc-release-4.16-e2e-aws-ovn/1785942839276867584 is totally due to my creation of test pods to troubleshoot by directly accessing to the cluster and forgot to delete it.

[ardaguclu]

/pj-rehearse ack

[openshift-ci-robot]

@ardaguclu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[ardaguclu]

/retest-required

[openshift-ci]

@ardaguclu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/oc/release-4.16/e2e-aws-ovn	a247763	link	unknown	/pj-rehearse pull-ci-openshift-oc-release-4.16-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.