Skip to content

WIP Ostree build#4900

Closed
vrutkovs wants to merge 17 commits intoopenshift:masterfrom
vrutkovs:ostree-build
Closed

WIP Ostree build#4900
vrutkovs wants to merge 17 commits intoopenshift:masterfrom
vrutkovs:ostree-build

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Aug 30, 2019 •
edited
Loading

Experiment with building ostree in api.ci

  • build_root image (centos7 w/ golang installed) is used to clone the project as it has necessary user set
  • ostree-ci is using F30 imagestream as a base for the dockerfile, which builds the code and runs minimal checks
  • sanity test runs a simple command to verify the binary has been built

TODO:

  • owners test fails as it doesn't have OWNERS filled in
  • config test fails as the repos are not configured to have Prow triggers
  • rpm-ostree build fails - wrong WORKDIR maybe?
  • ostree's sanity test fails during make install as its not running as root
  • Other tests fail as they can't run make clean to rebuild the package

Requires:

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 30, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign bparees
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters cgwalters mentioned this pull request Aug 30, 2019
Closed
@vrutkovs vrutkovs force-pushed the ostree-build branch 2 times, most recently from d5bda27 to d515a96 Compare August 30, 2019 15:13
@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Aug 30, 2019

ostree-ci is using F30 imagestream as a base for the dockerfile, which builds the code and runs minimal checks

I think we should use coreos/coreos-assembler#730

The workaround for the fedora-release bug is here btw coreos/rpm-ostree@0d841b2#diff-4347e55ee672a63c1ae3a89e57fa78eeR14

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Aug 30, 2019

I think we should use coreos/coreos-assembler#730

Good idea, added as TODO

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Aug 30, 2019

It's built in the coreos namespace to imagestream cosa-buildroot:latest...a namespace I just created and need to ensure other people have access to it.

Anyways registry.svc.ci.openshift.org/coreos/cosa-buildroot:latest should be pullable.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2019
@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Sep 5, 2019

@vrutkovs Are you still working on this?

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Sep 5, 2019

@cgwalters I am, I've got a few ideas to try tomorrow. Hopefully at least ostree's sanity test would pass soon, so later we can move on to running tests in CentOS CI

@dustymabe dustymabe mentioned this pull request Sep 5, 2019
Merged
cgwalters and others added 8 commits September 6, 2019 12:23
@cgwalters
Add ostreedev/ostree and projectatomic/rpm-ostree
91b9b80 
Currently, these projects are using [PAPR](https://github.com/projectatomic/papr/)
which today uses RHT-internal OpenStack which has reliability problems.

There's no reason not for us to add some usage of Prow as an additional
CI context; all we're doing is a build, no tests.

I am strongly considering switching to Prow as a "merge bot" too,
i.e. using `/lgtm` etc.  But this is just a first step.
Generate ostree tests from existing files and rework ostree/rpm-ostre…
6f88681 
…e configs
rpmostree - use existing cosa to make a new cosa buildroot
587ca2a
ci-operator/config/ostreedev/ostree/ostreedev-ostree-master: make ins…
ab68450 
…tall in sanity test
ci-operator/config/ostreedev/ostree/ostreedev-ostree-master: add more…
03f16a2 
… ostree tests
ci-operator/config/projectatomic/rpm-ostree/projectatomic-rpm-ostree-…
f855e0f 
…master: use f30 in rpmostree for now
Generate new jobs for ostree
50b935c
ci-operator/config/ostreedev/ostree/ostreedev-ostree-master: use sudo?
b0b5db6
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 6, 2019
ci-operator/config/projectatomic/rpm-ostree/projectatomic-rpm-ostree-…
24e5d6a 
…master: build Dockerfile, then buildroot and run tests there
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 6, 2019

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/ostreedev/ostree/master/yaml-lint 53c21e42afb3cce14e6a025fed31d31938070780 link /test pj-rehearse
ci/rehearse/ostreedev/ostree/master/primary 3026840776c3d24ad751329bf23247ad63b9dee9 link /test pj-rehearse
ci/rehearse/ostreedev/ostree/master/rust 609a5f9 link /test pj-rehearse
ci/rehearse/ostreedev/ostree/master/introspection 609a5f9 link /test pj-rehearse
ci/rehearse/ostreedev/ostree/master/gnutls 609a5f9 link /test pj-rehearse
ci/rehearse/ostreedev/ostree/master/libsoup 609a5f9 link /test pj-rehearse
ci/rehearse/ostreedev/ostree/master/minimal 609a5f9 link /test pj-rehearse
ci/prow/config d9fe7fa link /test config
ci/prow/owners d9fe7fa link /test owners
ci/rehearse/projectatomic/rpm-ostree/master/sanity d9fe7fa link /test pj-rehearse
ci/rehearse/projectatomic/rpm-ostree/master/images d9fe7fa link /test pj-rehearse
ci/rehearse/ostreedev/ostree/master/images d9fe7fa link /test pj-rehearse
ci/rehearse/ostreedev/ostree/master/sanity d9fe7fa link /test pj-rehearse
ci/prow/pj-rehearse d9fe7fa link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Oct 2, 2019

I took the rpm-ostree part of this to #5263
Let's do ostree once that's done and working well.
/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 2, 2019

@cgwalters: Closed this PR.

Details

In response to this:

I took the rpm-ostree part of this to #5263
Let's do ostree once that's done and working well.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@bparees bparees Awaiting requested review from bparees

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrutkovs @openshift-ci-robot @cgwalters