config: Add an rpm-ostree prow job by cgwalters · Pull Request #5263 · openshift/release

cgwalters · 2019-10-02T18:07:06Z

So we get "it builds and runs" sanity checking.

cgwalters · 2019-10-02T20:18:39Z

Hm, I don't understand these failures. This looks like fallout from ef3cd1d

vrutkovs · 2019-10-03T11:45:09Z

/retest

cgwalters · 2019-10-03T13:08:31Z

/retest

cgwalters · 2019-10-03T13:12:26Z

/test ci/prow/pj-rehearse

vrutkovs · 2019-10-03T13:42:29Z

ci-operator/config/coreos/rpm-ostree/OWNERS

These need reviewers so that we could LGTM PRs here

Approvers get used when no reviewers get listed

cgwalters · 2019-10-03T13:42:33Z

Hooray, this works now!

vrutkovs · 2019-10-03T13:42:43Z

ci-operator/jobs/coreos/rpm-ostree/OWNERS

These need reviewers so that we could LGTM PRs here

Aren't approvers also reviewers?

No, these are different - https://github.com/kubernetes/test-infra/tree/master/prow/plugins/approve/approvers#overview

Hmm but how does e.g. https://github.com/openshift/machine-config-operator/blob/master/OWNERS and https://github.com/openshift/cluster-version-operator/blob/master/OWNERS etc. work then?

Oh, it seems it works like this too

Can you /lgtm this?

jlebon

/lgtm

vrutkovs

/lgtm

ci-operator/config/coreos/rpm-ostree/coreos-rpm-ostree-master.yaml

So we get "it builds and runs" sanity checking.

petr-muller

/lgtm
/approve

stevekuznetsov

/lgtm
/approve

stevekuznetsov · 2019-10-03T15:13:30Z

ci-operator/config/coreos/rpm-ostree/OWNERS

Approvers get used when no reviewers get listed

stevekuznetsov · 2019-10-03T15:14:04Z

ci-operator/config/coreos/rpm-ostree/coreos-rpm-ostree-master.yaml

+resources:
+  '*':
+    limits:
+      memory: 6Gi


That's a lot of memory for your sanity test :)

Hm yeah, the build process (gcc and Rust compilers) is what uses RAM; could dial that back down some.

Ultimately I think what we really want is to

Attribute resource usage to repositories and organizations and keep it sane

https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler

openshift-ci-robot · 2019-10-03T15:14:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon, petr-muller, stevekuznetsov, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/OWNERS~~ [petr-muller,stevekuznetsov]
~~ci-operator/jobs/OWNERS~~ [petr-muller,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2019-10-03T15:17:10Z

@cgwalters: Updated the following 3 configmaps:

ci-operator-master-configs configmap in namespace ci-stg using the following files:
- key coreos-rpm-ostree-master.yaml using file ci-operator/config/coreos/rpm-ostree/coreos-rpm-ostree-master.yaml
job-config-master configmap in namespace ci using the following files:
- key coreos-rpm-ostree-master-presubmits.yaml using file ci-operator/jobs/coreos/rpm-ostree/coreos-rpm-ostree-master-presubmits.yaml
ci-operator-master-configs configmap in namespace ci using the following files:
- key coreos-rpm-ostree-master.yaml using file ci-operator/config/coreos/rpm-ostree/coreos-rpm-ostree-master.yaml

Details

In response to this:

So we get "it builds and runs" sanity checking.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 2, 2019

openshift-ci-robot requested review from bparees and stevekuznetsov October 2, 2019 18:07

cgwalters mentioned this pull request Oct 2, 2019

CI: Prow + "CoreOS CI" tracker coreos/fedora-coreos-tracker#263

Closed

cgwalters force-pushed the hookup-coreos-rpm-ostree-prowjob branch 2 times, most recently from 2634070 to e67360b Compare October 2, 2019 18:25

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 2, 2019

cgwalters force-pushed the hookup-coreos-rpm-ostree-prowjob branch from e67360b to 10e0a6d Compare October 2, 2019 18:30

cgwalters mentioned this pull request Oct 2, 2019

WIP Ostree build #4900

Closed

7 tasks

cgwalters force-pushed the hookup-coreos-rpm-ostree-prowjob branch 2 times, most recently from 2a15f3a to 780ad53 Compare October 2, 2019 20:04

cgwalters mentioned this pull request Oct 2, 2019

Determinize periodic jobs #5260

Merged

cgwalters closed this Oct 3, 2019

cgwalters reopened this Oct 3, 2019

cgwalters force-pushed the hookup-coreos-rpm-ostree-prowjob branch from 780ad53 to 3c643b6 Compare October 3, 2019 13:14

vrutkovs reviewed Oct 3, 2019

View reviewed changes

jlebon approved these changes Oct 3, 2019

View reviewed changes

openshift-ci-robot assigned jlebon Oct 3, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2019

vrutkovs approved these changes Oct 3, 2019

View reviewed changes

openshift-ci-robot assigned vrutkovs Oct 3, 2019

petr-muller reviewed Oct 3, 2019

View reviewed changes

ci-operator/config/coreos/rpm-ostree/coreos-rpm-ostree-master.yaml Outdated Show resolved Hide resolved

config: Add an rpm-ostree prow job

1611546

So we get "it builds and runs" sanity checking.

cgwalters force-pushed the hookup-coreos-rpm-ostree-prowjob branch from 3c643b6 to 1611546 Compare October 3, 2019 15:07

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2019

petr-muller approved these changes Oct 3, 2019

View reviewed changes

openshift-ci-robot assigned petr-muller Oct 3, 2019

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 3, 2019

stevekuznetsov reviewed Oct 3, 2019

View reviewed changes

openshift-ci-robot assigned stevekuznetsov Oct 3, 2019

openshift-merge-robot merged commit 91a96f9 into openshift:master Oct 3, 2019

Conversation

cgwalters commented Oct 2, 2019

Uh oh!

cgwalters commented Oct 2, 2019

Uh oh!

vrutkovs commented Oct 3, 2019

Uh oh!

cgwalters commented Oct 3, 2019

Uh oh!

cgwalters commented Oct 3, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgwalters commented Oct 3, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jlebon left a comment

Choose a reason for hiding this comment

Uh oh!

vrutkovs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

petr-muller left a comment

Choose a reason for hiding this comment

Uh oh!

stevekuznetsov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 3, 2019

Uh oh!

openshift-ci-robot commented Oct 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants