Closed
Conversation
Member
|
Please, let's use coreos/coreos-assembler#730 ? |
Member
|
We should be merging that today. |
Author
|
Does ostree need coreos-assembler as a base too? I'd rather use a minimal base image - and use coreos-assembler:buildroot for rpm-ostree specifically |
Member
|
I want ostree's tests to use cosa (and rpm-ostree), yes. |
vrutkovs
force-pushed
the
prow-dockerfiles
branch
from
cbd9bb9 to
795d943
Compare
Author
|
Sure, done |
7 tasks
Member
|
Sorry about the delay here...I think we ended up doing this in a different way, by having a shared fcos buildroot container image built elsewhere e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add helper dockerfiles for Prow builds. The base for all tests is
Dockerfile.buildrootwhich only contains builddeps. Other dockerfiles build ostree with various config options