More prow CI work#1893
Conversation
| COPY . . | ||
| RUN ./ci/build.sh | ||
| USER root | ||
| RUN env SKIP_INSTALLDEPS=1 ./ci/build-check.sh |
There was a problem hiding this comment.
I'd rather not run any kind of tests during image build here. These might fail and the resulting image cannot be used for other tests (unless make check and make rust-test are very-very basic)
There was a problem hiding this comment.
They're pretty basic tests.
That said, there is already today that split, we can just run ci/build.sh.
|
☔ The latest upstream changes (presumably 680cc10) made this pull request unmergeable. Please resolve the merge conflicts. |
We want to run the unit tests after a build, so do that. Furthermore, this actually installs the binaries, which means if we do it as part of a `Dockerfile` build, we can use that image for further testing.
|
Rebased, lifting WIP. |
See coreos/coreos-assembler#730 - Skip installing deps, hooray! - Also skip the C test suite for now because of the linked fuse-overlayfs issue
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
No description provided.