Enable byoh scaleup tests for MCO: always_run and optional. #3748
Conversation
openshift-ci-robot
added
the
size/L
There was a problem hiding this comment.
just to clarify, you made some tweaks to rhel scaleup here and also reordered the upgrade & scaleup in this file?
There was a problem hiding this comment.
@kikisdeliveryservice these files are generated by prowgen. I'm guessing it tries to keep them in alphabetical order, which unfortunately is making this harder to review. As best as I can tell there were no unintended changes to the upgrade job.
There was a problem hiding this comment.
ahhh thank you!! did not realize!
|
These are apparently generated files, which I did not realize. 👍 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: patrickdillon, vrutkovs If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
here we go first run failed with |
|
/retest |
1 similar comment
|
/retest |
|
Hold on here, the scaleup job isn't working properly and of little help anyway: The scaleup job brings in 2 CentOS 7 worker, QE tests with RHEL7.6. RHEL has CRI-O 1.13 which is the right one, CentOS 7 has CRI-O 1.12 which is completely wrong. We need to align on this or this job isn't reflecting reality in CI and what we test |
#3655 should have fixed the main issues with the scaleup job and we are starting to see some green (release-4.2 won't pass, but the other branches do). I am hoping if we turn this on as non-blocking we can start determining what are the issues specific to the scaleup tests and what are just e2e or installer flakes/issues.
@mtnbikenc @vrutkovs What do you think about this? |
the kubelet isn't also the one we're targeting with RHCOS (please check that as well) |
|
also, by "scaleup is of little help" I didn't mean to say the job per-se isn't valuable. Actually, I can see that the scaleup works great 99.999% of the time, what doesn't work isn't the scaleup, it's probably the mix of wrong components which make openshift tests fail for some reason. My aim is indeed to have this job setup properly and working! |
See #3759 |
openshift-ci-robot
added
the
needs-rebase
patrickdillon
force-pushed
the
rhel-scaleup-mco
branch
from
241e72e to
16ada23
Compare
|
New changes are detected. LGTM label has been removed. |
openshift-ci-robot
removed
the
needs-rebase
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
patrickdillon
force-pushed
the
rhel-scaleup-mco
branch
from
16ada23 to
681f67a
Compare
|
rebased |
|
/retest |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@patrickdillon: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
|
Scaleup tests are broken and we are waiting for updates to crio repos. Will reopen once scaleup tests are fixed. |
|
@patrickdillon The tests should be fixed now. crio is updated and we create the necessary dirs required for pods to start. |
6 participants
Replaces #3473 in order to be MCO specific.
Resolved issues that were plaguing #3473 by updating rhel scaleup template. #3620 is the equivalent of this PR for the installer repo and the master branch has been passing.