Always run RHEL scaleup in installer, MCO & MAO #3473

patrickdillon · 2019-04-15T16:56:55Z

Run BYOH tests on:

installer
machine-api operator
machine-config operator

More specifically this renames the tests to e2e-aws-scaleup-rhel7 and switches always_run to true.

NOTE I ignored warning messages like the following from prow-gen. Please let me know if that is a problem and I can try to rename the test:

WARN[0000] Generated job name is longer than 63 characters. This may cause issues when Prow attempts to label resources with job name. Consider a shorter name.  name=pull-ci-openshift-machine-config-operator-master-e2e-aws-scaleup-rhel7

patrickdillon · 2019-04-15T16:59:10Z

/cc vrutkovs

runcom · 2019-04-15T16:59:16Z

NOTE I ignored warning messages like the following from prow-gen. Please let me know if that is a problem and I can try to rename the test:

these shouldn't be an issue but I'm not entirely sure (I've had PR merged with this anyway)

this LGTM and can't wait to have it :)

vrutkovs · 2019-04-15T17:21:05Z

NOTE I ignored warning messages like the following from prow-gen. Please let me know if that is a problem and I can try to rename the test:
WARN[0000] Generated job name is longer than 63 characters. This may cause issues when Prow attempts to label resources with job name. Consider a shorter name.  name=pull-ci-openshift-machine-config-operator-master-e2e-aws-scaleup-rhel7

That's expected, yes

/lgtm

runcom · 2019-04-15T17:31:33Z

@patrickdillon: The following test failed, say /retest to rerun them all:

😢

runcom · 2019-04-15T17:31:56Z

aws limit error tho:

level=error msg="Error: Error applying plan:"
level=error
level=error msg="1 error occurred:"
level=error msg="\t* module.vpc.aws_route_table_association.route_net[0]: 1 error occurred:"
level=error msg="\t* aws_route_table_association.route_net.0: timeout while waiting for state to become 'success' (timeout: 5m0s)"

let's retest shortly

patrickdillon · 2019-04-16T01:10:12Z

/retest

vrutkovs · 2019-04-16T08:01:04Z

/retest

vrutkovs · 2019-04-16T08:56:22Z

https://rpms.svc.ci.openshift.org/openshift-origin-v4.1/repodata/repomd.xml: [Errno 14] HTTPS Error 404 - Not Found

Asked testplatform folks to create 4.1 repos

patrickdillon · 2019-04-22T17:11:31Z

/retest

patrickdillon · 2019-04-22T18:14:30Z

@vrutkovs lgtm got removed when I resoived merge conflicts. can you take another look?

patrickdillon · 2019-04-23T01:20:37Z

/retest

patrickdillon · 2019-04-24T01:16:40Z

/retest

patrickdillon · 2019-04-24T14:31:51Z

/retest

patrickdillon · 2019-04-24T20:11:30Z

/retest

patrickdillon · 2019-04-25T16:53:18Z

/retest

patrickdillon · 2019-04-25T17:58:12Z

/retest

patrickdillon · 2019-04-25T18:10:31Z

/retest

patrickdillon · 2019-04-25T18:12:03Z

/test ci/rehearse/openshift/installer/release-4.1/e2e-aws-scaleup-rhel7

patrickdillon · 2019-04-25T23:22:00Z

/retest

vrutkovs · 2019-04-26T07:13:07Z

/test pj-rehearse

openshift-ci-robot · 2019-04-26T11:13:51Z

@patrickdillon: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/machine-config-operator/release-4.1/e2e-aws-scaleup-rhel7	`798cd9c`	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/release-4.0/e2e-aws-scaleup-rhel7	`798cd9c`	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/release-4.1/e2e-aws-scaleup-rhel7	`798cd9c`	link	`/test pj-rehearse`
ci/rehearse/openshift/machine-config-operator/release-4.0/e2e-aws-scaleup-rhel7	`798cd9c`	link	`/test pj-rehearse`
ci/rehearse/openshift/installer/master/e2e-aws-scaleup-rhel7	`798cd9c`	link	`/test pj-rehearse`
ci/rehearse/openshift/machine-api-operator/master/e2e-aws-scaleup-rhel7	`798cd9c`	link	`/test pj-rehearse`
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-scaleup-rhel7	`798cd9c`	link	`/test pj-rehearse`
ci/rehearse/openshift/machine-api-operator/release-4.1/e2e-aws-scaleup-rhel7	`798cd9c`	link	`/test pj-rehearse`
ci/prow/pj-rehearse	`798cd9c`	link	`/test pj-rehearse`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vrutkovs

/lgtm

patrickdillon · 2019-04-26T16:21:08Z

/approve

openshift-ci-robot · 2019-04-26T16:21:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon, vrutkovs
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: cgwalters, spangenberg, tomassedovic

If they are not already assigned, you can assign the PR to them by writing /assign @cgwalters @spangenberg @tomassedovic in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

patrickdillon · 2019-04-26T16:36:40Z

/assign @cgwalters @spangenberg

patrickdillon · 2019-04-26T17:05:05Z

/hold
The rehearsals are too flakey. I'm going to consider breaking this into separate PRs, see if that helps.

michaelgugino

I'm not a fan of the implementation here: https://github.com/openshift/openshift-ansible/blob/master/test/aws/create_machineset.yml

The only thing that looks like it should be variable is the ami-id. Please create a proper template so it's easier to identify breakage in the future. As-is, we would have to reverse engineer what's actually being created in several places.

patrickdillon · 2019-04-26T17:23:29Z

/unassign @cgwalters @spangenberg

patrickdillon · 2019-05-02T14:27:08Z

I am closing this to break into separate PRs for each repo.

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2019

openshift-ci-robot requested review from ashcrow and runcom April 15, 2019 16:57

openshift-ci-robot requested a review from vrutkovs April 15, 2019 16:59

This was referenced Apr 15, 2019

mco: rename scaleup job to e2e-aws-scaleup-rhel7 #3232

Closed

machine-api-operator: rename scaleup job to e2e-aws-scaleup-rhel7 #3231

Closed

installer: rename scaleup job to e2e-aws-scaleup-rhel7 #3230

Closed

openshift-ci-robot assigned vrutkovs Apr 15, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019

patrickdillon force-pushed the installer-mco-mao-rhel-scaleup branch from 668e39a to 4b138a6 Compare April 22, 2019 18:12

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2019

patrickdillon mentioned this pull request Apr 23, 2019

Add origin 4.1 release artifacts #3556

Merged

patrickdillon mentioned this pull request Apr 24, 2019

Add openshift-origin-v4.1 rpm mirror. #3584

Merged

patrickdillon force-pushed the installer-mco-mao-rhel-scaleup branch from 4b138a6 to 645929d Compare April 24, 2019 20:20

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2019

patrickdillon force-pushed the installer-mco-mao-rhel-scaleup branch from 645929d to ce3351e Compare April 24, 2019 20:34

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2019

patrickdillon force-pushed the installer-mco-mao-rhel-scaleup branch from 28f4b7a to 4a41fb9 Compare April 25, 2019 15:06

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2019

Always run RHEL scaleup in installer, MCO & MAO repos.

798cd9c

patrickdillon force-pushed the installer-mco-mao-rhel-scaleup branch from 4a41fb9 to 798cd9c Compare April 25, 2019 18:13

vrutkovs approved these changes Apr 26, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019

openshift-ci-robot assigned cgwalters and spangenberg Apr 26, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2019

michaelgugino suggested changes Apr 26, 2019

View reviewed changes

openshift-ci-robot unassigned spangenberg and cgwalters Apr 26, 2019

patrickdillon mentioned this pull request Apr 27, 2019

Add rhel7 scaleup jobs to installer repo. #3620

Merged

patrickdillon closed this May 2, 2019

patrickdillon mentioned this pull request May 10, 2019

Enable byoh scaleup tests for MCO: always_run and optional. #3748

Closed

mtnbikenc mentioned this pull request Aug 20, 2019

MAO: Always run RHEL7 Scaleup tests #4801

Merged

Always run RHEL scaleup in installer, MCO & MAO #3473

Always run RHEL scaleup in installer, MCO & MAO #3473

Uh oh!

Conversation

patrickdillon commented Apr 15, 2019

Uh oh!

patrickdillon commented Apr 15, 2019

Uh oh!

runcom commented Apr 15, 2019

Uh oh!

vrutkovs commented Apr 15, 2019

Uh oh!

runcom commented Apr 15, 2019

Uh oh!

runcom commented Apr 15, 2019

Uh oh!

patrickdillon commented Apr 16, 2019

Uh oh!

vrutkovs commented Apr 16, 2019

Uh oh!

vrutkovs commented Apr 16, 2019

Uh oh!

patrickdillon commented Apr 22, 2019

Uh oh!

patrickdillon commented Apr 22, 2019

Uh oh!

patrickdillon commented Apr 23, 2019

Uh oh!

patrickdillon commented Apr 24, 2019

Uh oh!

patrickdillon commented Apr 24, 2019

Uh oh!

patrickdillon commented Apr 24, 2019

Uh oh!

patrickdillon commented Apr 25, 2019

Uh oh!

patrickdillon commented Apr 25, 2019

Uh oh!

patrickdillon commented Apr 25, 2019

Uh oh!

patrickdillon commented Apr 25, 2019

Uh oh!

patrickdillon commented Apr 25, 2019

Uh oh!

vrutkovs commented Apr 26, 2019

Uh oh!

openshift-ci-robot commented Apr 26, 2019

Uh oh!

vrutkovs left a comment

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Apr 26, 2019

Uh oh!

openshift-ci-robot commented Apr 26, 2019

Uh oh!

patrickdillon commented Apr 26, 2019

Uh oh!

patrickdillon commented Apr 26, 2019

Uh oh!

michaelgugino left a comment

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Apr 26, 2019

Uh oh!

patrickdillon commented May 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants