Skip to content

Add rhel7 scaleup jobs to installer repo. #3620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 17, 2019
Merged

Add rhel7 scaleup jobs to installer repo. #3620

openshift-merge-robot merged 1 commit into from
May 17, 2019

Conversation

@patrickdillon
Copy link
Contributor

@patrickdillon patrickdillon commented Apr 27, 2019

Jira: CORS-1059

More specifically this renames the tests to e2e-aws-scaleup-rhel7 and switches always_run to true.

This plan is to divide #3473 into a PR for each repo. This should be easier to get approval. Also want to see if the rehearsals get a higher passing rate.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 27, 2019
@droslean
Copy link
Member

droslean commented Apr 29, 2019

/test pj-rehearse

@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 2, 2019

/test pj-rehearse
scaleup template updated in #3655

@patrickdillon patrickdillon force-pushed the add-scaleup-installer branch 2 times, most recently from 134809c to 28e18b5 Compare May 3, 2019 00:23
@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 3, 2019

I updated these jobs to be optional. I am concerned about the combined flakiness of running two e2e tests.

@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 3, 2019

/test pj-rehearse

@patrickdillon patrickdillon force-pushed the add-scaleup-installer branch 3 times, most recently from 8f9f29d to a2f58aa Compare May 3, 2019 01:14
@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 3, 2019

/retest

2 similar comments
@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 3, 2019

/retest

@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 3, 2019

/retest

@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 3, 2019

/test pj-rehearse

@patrickdillon patrickdillon force-pushed the add-scaleup-installer branch from a2f58aa to 5088306 Compare May 3, 2019 20:19
@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 4, 2019

/retest

1 similar comment
@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 4, 2019

/retest

@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 5, 2019

/retest
master branch rehearsal is now passing with some regularity but other release branches have not ever passed. curious!

@patrickdillon patrickdillon force-pushed the add-scaleup-installer branch 2 times, most recently from a8a1bad to 265fc87 Compare May 9, 2019 00:18
@petr-muller
Copy link
Member

petr-muller commented May 9, 2019

/retest

Probably the GH hiccups yesterday

@patrickdillon patrickdillon force-pushed the add-scaleup-installer branch from 265fc87 to 4ed845a Compare May 9, 2019 10:24
@sdodson
Copy link
Member

sdodson commented May 9, 2019

master branch e2e-aws-scaleup-rhel7 is green
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2019
@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 9, 2019

@abhinavdahiya I rebased this. Master is passing. Release-4.1 is also passing, now that art updated the branch for beta 5.

@patrickdillon patrickdillon mentioned this pull request May 10, 2019
Closed
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2019
@patrickdillon patrickdillon force-pushed the add-scaleup-installer branch from 4ed845a to 8f635a4 Compare May 15, 2019 14:01
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2019
@patrickdillon patrickdillon force-pushed the add-scaleup-installer branch from 8f635a4 to 32bfaee Compare May 15, 2019 20:45
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2019
@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 16, 2019

/retest

@patrickdillon patrickdillon force-pushed the add-scaleup-installer branch from 32bfaee to 0a1d2e2 Compare May 16, 2019 15:32
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2019
@patrickdillon patrickdillon force-pushed the add-scaleup-installer branch from 0a1d2e2 to cb45470 Compare May 16, 2019 15:38
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2019
@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 16, 2019

/retest

2 similar comments
@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 17, 2019

/retest

@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 17, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 17, 2019

@patrickdillon: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/release-4.0/e2e-aws-scaleup-rhel7 cb45470 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.3/e2e-aws-scaleup-rhel7 cb45470 link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.2/e2e-aws-scaleup-rhel7 cb45470 link /test pj-rehearse
ci/prow/pj-rehearse cb45470 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor Author

patrickdillon commented May 17, 2019

@abhinavdahiya master & release-4.1 are passing. can you approve these?

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 17, 2019

/lgtm

this are optional and not required.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, patrickdillon, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9c79a25 into openshift:master May 17, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 17, 2019

@patrickdillon: Updated the following 15 configmaps:

  • ci-operator-4.0-configs configmap in namespace ci-stg using the following files:
    • key openshift-installer-release-4.0.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.0.yaml
  • ci-operator-4.1-configs configmap in namespace ci-stg using the following files:
    • key openshift-installer-release-4.1.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.1.yaml
  • ci-operator-4.3-configs configmap in namespace ci-stg using the following files:
    • key openshift-installer-release-4.3.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.3.yaml
  • ci-operator-4.0-configs configmap in namespace ci using the following files:
    • key openshift-installer-release-4.0.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.0.yaml
  • ci-operator-4.1-configs configmap in namespace ci using the following files:
    • key openshift-installer-release-4.1.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.1.yaml
  • ci-operator-4.3-configs configmap in namespace ci using the following files:
    • key openshift-installer-release-4.3.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.3.yaml
  • job-config-4.0 configmap in namespace ci using the following files:
    • key openshift-installer-release-4.0-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.0-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • job-config-4.1 configmap in namespace ci using the following files:
    • key openshift-installer-release-4.1-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.1-presubmits.yaml
  • job-config-4.3 configmap in namespace ci using the following files:
    • key openshift-installer-release-4.3-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.3-presubmits.yaml
  • ci-operator-4.2-configs configmap in namespace ci using the following files:
    • key openshift-installer-release-4.2.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.2.yaml
  • ci-operator-4.2-configs configmap in namespace ci-stg using the following files:
    • key openshift-installer-release-4.2.yaml using file ci-operator/config/openshift/installer/openshift-installer-release-4.2.yaml
  • job-config-master configmap in namespace ci using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
  • job-config-4.2 configmap in namespace ci using the following files:
    • key openshift-installer-release-4.2-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-release-4.2-presubmits.yaml
Details

In response to this:

Jira: CORS-1059

More specifically this renames the tests to e2e-aws-scaleup-rhel7 and switches always_run to true.

This plan is to divide #3473 into a PR for each repo. This should be easier to get approval. Also want to see if the rehearsals get a higher passing rate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@trown trown Awaiting requested review from trown

Assignees

@sdodson sdodson

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@patrickdillon @droslean @petr-muller @sdodson @openshift-ci-robot @abhinavdahiya @openshift-merge-robot