Skip to content

Conversation

@mtnbikenc
Copy link
Member

RHEL7 scaleup tests will always run but are not required

https://jira.coreos.com/browse/CORS-1059

Resubmit of #3473

RHEL7 scaleup tests will always run but are not required
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2019
@sdodson
Copy link
Member

sdodson commented Aug 28, 2019

/lgtm
@frobware PTAL, we'd like to make sure that repos that likely affect RHEL scaleup include RHEL scaleup tests, currently in a non blocking manner.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2019
@michaelgugino
Copy link
Contributor

I'm not really clear what the interface between MAO and RHEL is? Could you provide more details on how this would be helpful?

@frobware
Copy link
Contributor

Should this also be optional?

@sdodson
Copy link
Member

sdodson commented Aug 30, 2019

I'm not really clear what the interface between MAO and RHEL is? Could you provide more details on how this would be helpful?

@vrutkovs we wanted this because machine api was used to provision the RHEL instances or were there other dependencies on MAO specific to scaleup?

Should this also be optional?

Long term yes, only optional until success rate is sufficiently high that you'd be comfortable making it required.

@vrutkovs
Copy link
Contributor

@vrutkovs we wanted this because machine api was used to provision the RHEL instances or were there other dependencies on MAO specific to scaleup?

Correct, our tests are creating machine via MAO so in order to keep tests stable we should ensure MAO changes won't break them

@frobware
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, mtnbikenc, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9b5b388 into openshift:master Aug 30, 2019
@openshift-ci-robot
Copy link
Contributor

@mtnbikenc: Updated the following 4 configmaps:

  • job-config-4.2 configmap in namespace ci using the following files:
    • key openshift-machine-api-operator-release-4.2-presubmits.yaml using file ci-operator/jobs/openshift/machine-api-operator/openshift-machine-api-operator-release-4.2-presubmits.yaml
  • job-config-4.3 configmap in namespace ci using the following files:
    • key openshift-machine-api-operator-release-4.3-presubmits.yaml using file ci-operator/jobs/openshift/machine-api-operator/openshift-machine-api-operator-release-4.3-presubmits.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key openshift-machine-api-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-api-operator/openshift-machine-api-operator-master-presubmits.yaml
  • job-config-4.1 configmap in namespace ci using the following files:
    • key openshift-machine-api-operator-release-4.1-presubmits.yaml using file ci-operator/jobs/openshift/machine-api-operator/openshift-machine-api-operator-release-4.1-presubmits.yaml
Details

In response to this:

RHEL7 scaleup tests will always run but are not required

https://jira.coreos.com/browse/CORS-1059

Resubmit of #3473

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtnbikenc mtnbikenc deleted the mao-run-scaleup branch August 30, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants