add installer nested libvirt template #2143
Conversation
openshift-ci-robot
added
the
size/L
sallyom
force-pushed
the
add-nested-libvirt-template
branch
3 times, most recently
from
127db17 to
a45bbf7
Compare
ci-operator/README.md
Outdated
There was a problem hiding this comment.
Omit the line number as it's not going to be relevant a few commits later
sallyom
force-pushed
the
add-nested-libvirt-template
branch
from
a45bbf7 to
ff2bcd7
Compare
There was a problem hiding this comment.
Why is this so different than other types of testing?
Is your job not intended to run tests?
There was a problem hiding this comment.
this template is to install a libvirt cluster, to test the libvirt setup is not broken, for developers' workflow. This was requested by the installer team.
There was a problem hiding this comment.
It checks nodes/workers/router is up for now, will add more tests in a follow-up.
There was a problem hiding this comment.
I've added openshift-tests
cluster/ci/config/prow/plugins.yaml
Outdated
There was a problem hiding this comment.
cluster-launch-installer-libvirt-e2e.yaml
sallyom
force-pushed
the
add-nested-libvirt-template
branch
from
ff2bcd7 to
042bda3
Compare
ci-operator/README.md
Outdated
There was a problem hiding this comment.
Can this be a relative link?
... configuration file](../cluster/ci/config/prow/plugins.yaml)
There was a problem hiding this comment.
I'm going to leave it as/is, bc it goes along with the other links in the doc.
There was a problem hiding this comment.
Can we drop this trailing empty line?
There was a problem hiding this comment.
Do you need the - here? I'm not used to seeing it.
There was a problem hiding this comment.
nope, don't need it, the hyphen is used when appending or prepending typed text to an existing file to create a new file, so that does not belong here, thanks :)
sallyom
force-pushed
the
add-nested-libvirt-template
branch
4 times, most recently
from
3a6ed3a to
f0b9fe9
Compare
There was a problem hiding this comment.
@smarterclayton I've added openshift-tests binary to the installer-libvirt image, here: openshift/installer@master...sallyom:add-openshift-tests-to-libvirt-ci-image - is there a better/easier way to do get openshift-tests in the test container?
There was a problem hiding this comment.
Why do you need the binary inside your image, vs just passing a kubeconfig to the test pod? is your gce libvirt cluster not available outside?
There was a problem hiding this comment.
That change to installer won't work - you can't do that. :)
There was a problem hiding this comment.
nm, I'm taking it from IMAGE_TESTS, got it.
sallyom
force-pushed
the
add-nested-libvirt-template
branch
from
f0b9fe9 to
e4c99e1
Compare
sallyom
force-pushed
the
add-nested-libvirt-template
branch
from
e4c99e1 to
128c374
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sallyom: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…bvirt-e2e: Drop IMAGE_INSTALLER This parameter dates back to 128c374 (add installer nested libvirt template, 2018-11-14, openshift#2143), but has never been used (this template uses LOCAL_IMAGE_LIBVIRT_INSTALLER instead).
6 participants
@stevekuznetsov I think this is required before a PR to add a libvirt test and job to openshift/installer. thanks!
depends on this: openshift/installer#701 fornm, got it from IMAGE_TESTSopenshift-testsbinary, but maybe there's a better way to get that binary available to test container?