Skip to content

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Nov 19, 2018

@wking
For the CI libvirt template, I'm adding the openshift-tests binary, enabling the libvirt CI job to run the same tests as our other e2e jobs. This makes the libvirt-installer CI image build take a considerably longer time, so if there is a better way to get openshift-tests into the CI test container I'll close this PR.

depends on this: openshift/release#2143

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sallyom
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hardys

If they are not already assigned, you can assign the PR to them by writing /assign @hardys in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2018
@wking
Copy link
Member

wking commented Nov 19, 2018

Can we add it to the release image like this? Then we can pull the openshift-test image at runtime with the same pull secret we used to create the cluster, and we don't have to build it in here.

@sallyom
Copy link
Contributor Author

sallyom commented Nov 19, 2018

@wking I'll give that a try, will close this PR if so, thanks!

Yes, this PR is not needed, I'm getting openshift-tests from the CLI image in the cluster.

@openshift-ci-robot
Copy link
Contributor

@sallyom: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 54b7a86 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sallyom sallyom closed this Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants