Skip to content

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Nov 6, 2018

Adding job to openshift-installer against a 4.0 libvirt install. This has been requested because developers depend on the libvirt workflow with openshift/installer. Keeping this job optional for now until we know it's reliable.
Depends on openshift/installer#625

@stevekuznetsov for this job, we'll need:

this needs to merge first #2143

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2018
@sallyom sallyom force-pushed the add-libvirt-installer-ci branch 3 times, most recently from ec439fd to 2446e3e Compare November 7, 2018 21:05
@sallyom sallyom changed the title WIP: Add gcp nested libvirt openshift installer Add gcp nested libvirt openshift installer Nov 7, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2018
@sallyom sallyom force-pushed the add-libvirt-installer-ci branch 20 times, most recently from b61b948 to 06aeed0 Compare November 13, 2018 20:30
@sallyom sallyom force-pushed the add-libvirt-installer-ci branch 4 times, most recently from 80243f7 to e345710 Compare November 14, 2018 01:03
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2018
@sallyom sallyom force-pushed the add-libvirt-installer-ci branch from e345710 to 19d622d Compare November 14, 2018 01:19
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2018
@sallyom sallyom force-pushed the add-libvirt-installer-ci branch 7 times, most recently from 38fd929 to b412b46 Compare November 20, 2018 20:57
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2018
@sallyom sallyom force-pushed the add-libvirt-installer-ci branch 5 times, most recently from 53da0e5 to 1065cfb Compare November 21, 2018 18:19
@sallyom sallyom force-pushed the add-libvirt-installer-ci branch from 1065cfb to 88d28f5 Compare November 21, 2018 19:17
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2018
@openshift-merge-robot openshift-merge-robot merged commit c89dde5 into openshift:master Nov 21, 2018
@openshift-ci-robot
Copy link
Contributor

@sallyom: Updated the following 2 configmaps:

  • ci-operator-configs configmap using the following files:
    • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
  • job-config configmap using the following files:
    • key openshift-installer-master-presubmits.yaml using file ci-operator/jobs/openshift/installer/openshift-installer-master-presubmits.yaml
Details

In response to this:

Adding job to openshift-installer against a 4.0 libvirt install. This has been requested because developers depend on the libvirt workflow with openshift/installer. Keeping this job optional for now until we know it's reliable.
Depends on openshift/installer#625

@stevekuznetsov for this job, we'll need:

this needs to merge first #2143

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants