-
Notifications
You must be signed in to change notification settings - Fork 2k
Add gcp nested libvirt openshift installer #2078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gcp nested libvirt openshift installer #2078
Conversation
ec439fd to
2446e3e
Compare
b61b948 to
06aeed0
Compare
80243f7 to
e345710
Compare
e345710 to
19d622d
Compare
38fd929 to
b412b46
Compare
53da0e5 to
1065cfb
Compare
1065cfb to
88d28f5
Compare
stevekuznetsov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sallyom: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Adding job to openshift-installer against a 4.0 libvirt install. This has been requested because developers depend on the libvirt workflow with openshift/installer. Keeping this job optional for now until we know it's reliable.
Depends on openshift/installer#625
@stevekuznetsov for this job, we'll need:
the quaydonepull-secretfromcluster-secrets-awscopied into thecluster-secrets-gcpsecret.2 images necessary for the install inopenshift-gce-devel-ciproject, from this repo: https://github.com/sallyom/openshift4-libvirt-gcp/tree/ci-openshift4-libvirt-gcp and withpacker build openshift4-libvirt-source.jsonandpacker build openshift4-libvirt.jsonthis needs to merge first #2143