Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Apr 1, 2019

This parameter dates back to 128c374 (#2143), but has never been used (this template uses LOCAL_IMAGE_LIBVIRT_INSTALLER instead).

CC @sallyom

…bvirt-e2e: Drop IMAGE_INSTALLER

This parameter dates back to 128c374 (add installer nested libvirt
template, 2018-11-14, openshift#2143), but has never been used (this template
uses LOCAL_IMAGE_LIBVIRT_INSTALLER instead).
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2019
@wking
Copy link
Member Author

wking commented Apr 1, 2019

correctly-sharded-config:

[ERROR] The following errors were found:

time="2019-04-01T18:38:08Z" level=warning msg="Failed to determine info for prow job config" error="file name was not prefixed with \"ci-operator-jobs-\": \"infra-periodics\"" source-file=ci-operator/jobs/infra-periodics.yaml
time="2019-04-01T18:38:09Z" level=error msg="File matches glob from unexpected ConfigMap." glob="ci-operator/jobs/openshift/external-dns/*openshift-4.0*.yaml" source-file=ci-operator/jobs/openshift/external-dns/openshift-external-dns-openshift-4.0-postsubmits.yaml
time="2019-04-01T18:38:09Z" level=error msg="File matches glob from unexpected ConfigMap." glob="ci-operator/jobs/openshift/external-dns/*openshift-4.0*.yaml" source-file=ci-operator/jobs/openshift/external-dns/openshift-external-dns-openshift-4.0-presubmits.yaml
time="2019-04-01T18:38:10Z" level=fatal msg="Found configurations that do not belong to the correct auto-updating config"

Can someone translate that to English for me? I didn't touch anything under jobs...

@wking
Copy link
Member Author

wking commented Apr 1, 2019

Ah, probably will be fixed by #3319.

@csrwng
Copy link
Contributor

csrwng commented Apr 1, 2019

/retest

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 57b64e0 into openshift:master Apr 2, 2019
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 2 configmaps:

  • prow-job-cluster-launch-installer-libvirt-e2e configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
  • prow-job-cluster-launch-installer-libvirt-e2e configmap in namespace ci using the following files:
    • key cluster-launch-installer-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
Details

In response to this:

This parameter dates back to 128c374 (#2143), but has never been used (this template uses LOCAL_IMAGE_LIBVIRT_INSTALLER instead).

CC @sallyom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the drop-installer-image-from-libvirt-e2e branch April 25, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants