Skip to content

NO-JIRA: Handle release info output streams separately#28631

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ardaguclu:fix-release-info-output
Feb 29, 2024
Merged

NO-JIRA: Handle release info output streams separately#28631
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ardaguclu:fix-release-info-output

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Feb 29, 2024 •
edited
Loading

This PR handles release info command's output streams separately instead of merging them. Because
test does not need the data in errOut.

@openshift-ci openshift-ci bot requested review from mfojtik and sdodson February 29, 2024 04:21
@ardaguclu ardaguclu changed the title Handle release info output streams separately NO-JIRA: Handle release info output streams separately Feb 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 29, 2024

@ardaguclu: This pull request explicitly references no jira issue.

Details

In response to this:

This PR handles release info command's output streams separately instead of merging them. Because
test does not need the data in errOut.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

soltysh
soltysh approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@soltysh
Copy link
Contributor

soltysh commented Feb 29, 2024

/retest-required

@jcpowermac jcpowermac mentioned this pull request Feb 29, 2024
Merged
@martinkennelly martinkennelly mentioned this pull request Feb 29, 2024
Merged
@r4f4 r4f4 mentioned this pull request Feb 29, 2024
Merged
@vr4manta vr4manta mentioned this pull request Feb 29, 2024
Merged
@ardaguclu
Copy link
Member Author

ardaguclu commented Feb 29, 2024

/retest-required

@grokspawn grokspawn mentioned this pull request Feb 29, 2024
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 85776b9 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade 85776b9 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-single-node-serial 85776b9 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8696130 into openshift:master Feb 29, 2024
@ardaguclu ardaguclu deleted the fix-release-info-output branch February 29, 2024 19:46
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 1, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202403010139.p0.g8696130.assembly.stream.el8 for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@danwinship danwinship mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@sdodson sdodson Awaiting requested review from sdodson

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ardaguclu @openshift-ci-robot @soltysh @openshift-bot