SPLAT-1173: Enhance vSphere Installer to use IPAddressClaims for static IP#7501
Conversation
|
@vr4manta: This pull request references SPLAT-1173 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@vr4manta: This pull request references SPLAT-1173 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
pkg/asset/machines/master.go
Outdated
There was a problem hiding this comment.
unable to marshal ipaddress %v
pkg/asset/machines/master.go
Outdated
There was a problem hiding this comment.
unable to marshal ipaddressclaim %v
pkg/asset/machines/master.go
Outdated
There was a problem hiding this comment.
change to: "unable to unmarshal ipaddress %d"
There was a problem hiding this comment.
I was using same error message from the lines prior to this where the same activities are being done. For consistency, should I also update the other error messages to add "unable to "?
There was a problem hiding this comment.
i dont think that's necessary, was just thinking it might clarify the error.
|
@rvanderp3: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test go-lint |
|
@rvanderp3: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test golint |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@vr4manta: This pull request references SPLAT-1173 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold pending #7418 |
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
the
do-not-merge/hold
openshift-merge-robot
removed
the
needs-rebase
|
/reopen |
|
/retest |
1 similar comment
|
/retest |
|
@JoelSpeed @patrickdillon , this PR is now ready for review / approval. |
|
/lgtm |
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon, rvanderp3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
looks like I'm hitting the issue fixed by openshift/origin#28631 |
|
/override ci/prow/e2e-aws-ovn ci/prow/e2e-vsphere-ovn |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-aws-ovn, ci/prow/e2e-vsphere-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws-ovn ci/prow/e2e-vsphere-ovn |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-aws-ovn, ci/prow/e2e-vsphere-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.16.0-202403010139.p0.g62209ca.assembly.stream.el8 for distgit ose-installer-altinfra. |
8 participants
SPLAT-1173
Changes
Dependencies
Notes