Skip to content

CORS-3273: capi system: don't log env vars#8084

Merged
patrickdillon merged 1 commit intoopenshift:masterfrom
patrickdillon:capi-controller-logging
Feb 29, 2024
Merged

CORS-3273: capi system: don't log env vars#8084
patrickdillon merged 1 commit intoopenshift:masterfrom
patrickdillon:capi-controller-logging

Conversation

@patrickdillon
Copy link
Contributor

Only log process args.

Only log process args, env vars may contain sensitive data.
@patrickdillon
Copy link
Contributor Author

/test altinfra-e2e-aws-capi-ovn

@r4f4
Copy link
Contributor

r4f4 commented Feb 29, 2024

/retitle CORS-3273: capi system: don't log env vars

@openshift-ci openshift-ci bot changed the title capi system: don't log env vars CORS-3273: capi system: don't log env vars Feb 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 29, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 29, 2024

@patrickdillon: This pull request references CORS-3273 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Only log process args.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@patrickdillon
Copy link
Contributor Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b8d5671 and 2 for PR HEAD 1a01685 in total

@patrickdillon
Copy link
Contributor Author

/skip
/override ci/prow/altinfra-e2e-aws-capi-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/altinfra-e2e-aws-capi-ovn

Details

In response to this:

/skip
/override ci/prow/altinfra-e2e-aws-capi-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor Author

/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws-ovn

Details

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Feb 29, 2024

e2e-aws-ovn: failing from a known issue openshift/origin#28631

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 1a01685 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor Author

manually merging this for priority

@patrickdillon patrickdillon merged commit fcef1d3 into openshift:master Feb 29, 2024
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202402291846.p0.gfcef1d3.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments