Skip to content

Run hypershift-aws-conformance, not hypershift-aws-e2e-external in CNO#49356

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
danwinship:cno-hypershift
Mar 1, 2024
Merged

Run hypershift-aws-conformance, not hypershift-aws-e2e-external in CNO#49356
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
danwinship:cno-hypershift

Conversation

@danwinship
Copy link
Contributor

hypershift-aws-e2e-external is an "install a hypershift cluster and then run hypershift-related tests" job, while hypershift-aws-conformance is "install a hypershift cluster and then run the ocp e2e test suite", which sounds more like what we want. More importantly, it doesn't have a crazy flake rate.

/assign @jluhrsen

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@openshift-ci openshift-ci bot requested review from dougbtv and tssurya February 28, 2024 23:11
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@danwinship: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-hypershift-ovn openshift/cluster-network-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-network-operator-master-e2e-hypershift-ovn openshift/cluster-network-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-network-operator-release-4.15-e2e-hypershift-ovn openshift/cluster-network-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-network-operator-release-4.14-e2e-hypershift-ovn openshift/cluster-network-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-network-operator-release-4.16-e2e-hypershift-ovn openshift/cluster-network-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@danwinship
Copy link
Contributor Author

/pj-rehearse

@jluhrsen
Copy link
Contributor

i like it
/lgtm

if the rehearsals are good, just ack them and it'll land.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, jluhrsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danwinship
Copy link
Contributor Author

/pj-rehearse

@danwinship
Copy link
Contributor Author

The 4.17 run is failing because... something seems to be missing? Presumably it will get fixed at some point...

AFAICT, the 4.16/master runs are failing because a particular oc invocation is printing a warning (presumably something new in 4.16) which an e2e test then tries to parse as json and fails. But it doesn't print enough info to debug and I can't reproduce it in a normal hypershift cluster...

@danwinship
Copy link
Contributor Author

/pj-rehearse

openshift/origin#28631 should fix the 4.16/master problem

@danwinship
Copy link
Contributor Author

/pj-rehearse ack

4.14 failure seems to be a flake (or someone other than us broke something temporarily; it worked in previous runs)
4.17 failure is because of something not being set up right in release-4.17 which will presumably be fixed well before we actually have release-4.17 PRs

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-network-operator/release-4.17/e2e-hypershift-ovn 8f68138 link unknown /pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.17-e2e-hypershift-ovn
ci/rehearse/openshift/cluster-network-operator/release-4.14/e2e-hypershift-ovn 8f68138 link unknown /pj-rehearse pull-ci-openshift-cluster-network-operator-release-4.14-e2e-hypershift-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8e1d390 into openshift:master Mar 1, 2024
@danwinship danwinship deleted the cno-hypershift branch March 1, 2024 16:46
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants