Bug 1962502: Create custom metrics to list unmanaged Routes and Ingresses without IngressClassName

[suleymanakbas91]

This PR adds two custom metrics to count the number of ingresses without IngressClassName and the number of routes owned by ingresses no longer managed.

• pkg/route/ingress/ingress.go: Registers metrics to the KubeRegistry. Moves the logic to determine which ingresses are managed to a separate ingressManaged function.
• pkg/route/ingress/metrics.go: Implements Registrable interface so that the metrics can be registered to the KubeRegistry. Creates the metrics and implements the collector for the metrics.
• pkg/route/ingress/metrics_test.go: Adds unit-test for the metrics.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

@suleymanakbas91: This pull request references Bugzilla bug 1962502, which is invalid:

• expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1962502: Create custom metrics to list unmanaged Routes and Ingre…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[suleymanakbas91]

/bugzilla refresh

[openshift-ci]

@suleymanakbas91: This pull request references Bugzilla bug 1962502, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: suleymanakbas91
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval by writing /assign @miciah in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/route/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[suleymanakbas91]

/test all

[openshift-ci]

@suleymanakbas91: This pull request references Bugzilla bug 1962502, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Bug 1962502: Create custom metrics to list unmanaged Routes and Ingresses without IngressClassName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@suleymanakbas91: This pull request references Bugzilla bug 1962502, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

Details

In response to this:

Bug 1962502: Create custom metrics to list unmanaged Routes and Ingresses without IngressClassName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[quarterpin]

/label qe-approved

Verified via pre-merge workflow. More details can be found in : https://bugzilla.redhat.com/show_bug.cgi?id=1962502#c4

[candita]

/assign
/assign @rfredette

[suleymanakbas91]

/retest

[candita]

/retest

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[candita]

@suleymanakbas91 can you explain why was the decision made to add the metrics here instead of in cluster-ingress-operator?

[atiratree]

@suleymanakbas91 fyi #240 removes these controllers from OCM repo. Any future PRs should go to https://github.com/openshift/route-controller-manager from now on

[suleymanakbas91]

Moving this to route-controller-manager: openshift/route-controller-manager#8

[openshift-ci]

@suleymanakbas91: This pull request references Bugzilla bug 1962502. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1962502: Create custom metrics to list unmanaged Routes and Ingresses without IngressClassName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[candita]

I will reassign myself and Ryan to the new PR