Bug 1962502: Create custom metrics to list unmanaged Routes and Ingresses without IngressClassName

[suleymanakbas91]

This PR adds two custom metrics to count the number of ingresses without IngressClassName and the number of routes owned by ingresses no longer managed.

• pkg/route/ingress/ingress.go: Registers metrics to the KubeRegistry. Moves the logic to determine which ingresses are managed to a separate ingressManaged function.
• pkg/route/ingress/metrics.go: Implements Registrable interface so that the metrics can be registered to the KubeRegistry. Creates the metrics and implements the collector for the metrics.
• pkg/route/ingress/metrics_test.go: Adds unit-test for the metrics.

[openshift-ci]

@suleymanakbas91: This pull request references Bugzilla bug 1962502, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Bug 1962502: Create custom metrics to list unmanaged Routes and Ingresses without IngressClassName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@suleymanakbas91: This pull request references Bugzilla bug 1962502, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.12.0) matches configured target release for branch (4.12.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

Details

In response to this:

Bug 1962502: Create custom metrics to list unmanaged Routes and Ingresses without IngressClassName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[candita]

/assign
/assign @rfredette

[suleymanakbas91]

/retest

[suleymanakbas91]

/retest

[suleymanakbas91]

/retest

[openshift-ci]

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[candita]

/approve

[Miciah]

/approve

[Miciah]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, Miciah, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/route/OWNERS [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@suleymanakbas91: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/cluster-ingress-operator#823 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1962502 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1962502: Create custom metrics to list unmanaged Routes and Ingresses without IngressClassName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.