Skip to content

Remove route controllers #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 4 commits into from
Oct 6, 2022
Merged

Remove route controllers #240

openshift-merge-robot merged 4 commits into from
Oct 6, 2022

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Sep 29, 2022

  • Ingress to Route Controller
  • Service Ingress IP Controller

they were moved into https://github.com/openshift/route-controller-manager

@openshift-ci openshift-ci bot requested review from frobware and mfojtik September 29, 2022 20:48
@atiratree atiratree mentioned this pull request Sep 29, 2022
Closed
@ingvagabund
Copy link
Member

ingvagabund commented Sep 29, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
@atiratree
Copy link
Member Author

atiratree commented Sep 30, 2022

/retest

@atiratree
Copy link
Member Author

atiratree commented Sep 30, 2022

there was a mixup in the operator PR with image names so we have to hold for now: openshift/cluster-openshift-controller-manager-operator#265

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2022
@atiratree
Copy link
Member Author

atiratree commented Oct 6, 2022

route-controller-image has been included in the payload
/hold cancel
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openshift-e2e-aws-builds-techpreview 663e606 link false /test openshift-e2e-aws-builds-techpreview
ci/prow/e2e-aws-proxy 663e606 link false /test e2e-aws-proxy

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2022
@atiratree
Copy link
Member Author

atiratree commented Oct 6, 2022

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Oct 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 80d2299 into openshift:master Oct 6, 2022
@csrwng csrwng mentioned this pull request Oct 6, 2022
Merged
1 task
@Miciah Miciah mentioned this pull request Sep 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frobware frobware Awaiting requested review from frobware

@mfojtik mfojtik Awaiting requested review from mfojtik

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ingvagabund ingvagabund

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atiratree @ingvagabund @soltysh @openshift-merge-robot