Handling Azure Parameters in CI Env using templates. by deepakraj1997 · Pull Request #582 · openshift/oadp-operator

deepakraj1997 · 2022-03-02T18:53:19Z

Moved most of the parameters to templates and scripts
Removed redundant code and unused functions.

openshift-ci · 2022-03-02T18:53:22Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

deepakraj1997 · 2022-03-02T18:55:07Z

/test all

deepakraj1997 · 2022-03-02T18:55:39Z

/uncc alaypatel07 JaydipGabani

deepakraj1997 · 2022-03-03T18:33:53Z

/test all

deepakraj1997 · 2022-03-04T14:49:54Z

/test all

deepakraj1997 · 2022-03-04T16:15:35Z

/test all

deepakraj1997 · 2022-03-07T02:44:35Z

/test all

deepakraj1997 · 2022-03-08T16:25:11Z

/test operator-e2e-azure

deepakraj1997 · 2022-03-23T07:12:57Z

/test operator-e2e-azure

deepakraj1997 · 2022-03-28T14:18:28Z

/test operator-e2e-azure

deepakraj1997 · 2022-03-28T15:59:08Z

/test operator-e2e-azure

deepakraj1997 · 2022-03-29T13:22:15Z

/test operator-e2e-azure

deepakraj1997 · 2022-03-29T14:54:06Z

/test operator-e2e-azure

deepakraj1997 · 2022-03-29T17:04:58Z

/test all

deepakraj1997 · 2022-03-31T14:37:15Z

/retest

deepakraj1997 · 2022-03-31T19:09:03Z

/retest

weshayutin · 2022-04-18T15:12:22Z

/retest

kaovilai · 2022-04-19T19:57:26Z

/retest

deepakraj1997 · 2022-04-20T17:38:43Z

/retest

deepakraj1997 · 2022-04-21T14:43:19Z

/retest

deepakraj1997 · 2022-04-21T17:05:10Z

/retest

openshift-ci · 2022-04-21T18:27:30Z

@deepakraj1997: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

weshayutin · 2022-04-22T14:08:57Z

/lgtm

kaovilai · 2022-04-29T04:51:43Z

looks like I made a conflicting PR #651 heh

kaovilai · 2022-04-29T04:52:38Z

If this can merge I'll merge this first.

* Adding azure parameters * Adding Openshift CI params * Update Test Suite and Helpers * Adding cred ref * Adding cred ref * Changing azure oadp cred dir to tmp * Fixing duplicate error * Removing OpenShift CI * Changing test instance name * Changing the AWS BSL Profile to default * Changing BslMountPath variable in registry controller

…n updateRegistrySecret (#679) * Replace carriage return when getting provider secrets for registry + E2E changes (#652) * Replace carriage return when getting provider secrets for registry Co-authored-by: GitHub Co-pilot <idkwhatemailgithubcopilotuses@github.com> * add tests * replaceCarriageReturn unit test * Registry credentials can use other secret names Co-authored-by: GitHub Co-pilot <idkwhatemailgithubcopilotuses@github.com> * Multi cloud E2E Updates (#568) * Adding changes from ci-multi-cloud branch * Updating flags in makefile * Updating flags in makefile * Updating flags in makefile * Update defaults * Fix helpers * Cleaning up makefile * Update makefile * Update kustomization * Cleaning up Makefile * Adding changes for AWS CredentialFile * Handling no default backuplocations * Removing comments * Adding config check in helpers * Fix AWS Test case * Fix basic review comments * genericTests... * Changing Credentials Mount Name for BSL when CredentialsFile key is used in Config - Fixes CI (#637) * Changing Credentials Mount Name for BSL for GCP * Fix DefaultPlugin for credentialsFile * E2E Tests: Fix azure templating name. (#573) * Fixing Azure to run locally * Aligning json * Handling Azure Parameters in CI Env using templates. (#582) * Adding azure parameters * Adding Openshift CI params * Update Test Suite and Helpers * Adding cred ref * Adding cred ref * Changing azure oadp cred dir to tmp * Fixing duplicate error * Removing OpenShift CI * Changing test instance name * Changing the AWS BSL Profile to default * Changing BslMountPath variable in registry controller * Replace carriage return when getting provider secrets for registry + E2E changes (#652) * Replace carriage return when getting provider secrets for registry Co-authored-by: GitHub Co-pilot <idkwhatemailgithubcopilotuses@github.com> * add tests * replaceCarriageReturn unit test * Registry credentials can use other secret names Co-authored-by: GitHub Co-pilot <idkwhatemailgithubcopilotuses@github.com> * fix missing err return for updateRegistrySecret function * go fmt * upgraded ginkgo on tests to ginkgo 2.0 (#560) Co-authored-by: Nitish Srivastava <43022982+nitishSr@users.noreply.github.com> Co-authored-by: GitHub Co-pilot <idkwhatemailgithubcopilotuses@github.com> Co-authored-by: Deepak Raj D S <drajds@redhat.com> Co-authored-by: Shubham Pampattiwar <shubhampampattiwar7@gmail.com> Co-authored-by: Maya Peretz <mperetz@redhat.com>

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2022

openshift-ci Bot requested review from JaydipGabani and alaypatel07 March 2, 2022 18:54

deepakraj1997 changed the base branch from master to ci-multi-cloud March 2, 2022 18:54

openshift-ci Bot removed request for JaydipGabani and alaypatel07 March 2, 2022 18:55

deepakraj1997 changed the title ~~Handling Azure Parameters in CI Env using templates.~~ [WIP] Handling Azure Parameters in CI Env using templates. Mar 2, 2022

deepakraj1997 changed the base branch from ci-multi-cloud to master March 29, 2022 17:03

deepakraj1997 marked this pull request as ready for review March 31, 2022 16:01

openshift-ci Bot requested review from alaypatel07 and shubham-pampattiwar March 31, 2022 16:04

deepakraj1997 force-pushed the multi-cloud-template branch from f4941d7 to 3f293cf Compare March 31, 2022 18:48

deepakraj1997 changed the title ~~[WIP] Handling Azure Parameters in CI Env using templates.~~ Handling Azure Parameters in CI Env using templates. Apr 5, 2022

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2022

deepakraj1997 added 10 commits April 20, 2022 10:24

Adding azure parameters

f3969e9

Adding Openshift CI params

553b16a

Update Test Suite and Helpers

e1b8acc

Adding cred ref

d6bf284

Adding cred ref

8083c1a

Changing azure oadp cred dir to tmp

79ac956

Fixing duplicate error

c2ed3b8

Removing OpenShift CI

bf917af

Changing test instance name

7b500b7

Changing the AWS BSL Profile to default

f0d62c8

deepakraj1997 force-pushed the multi-cloud-template branch from 9cb0d54 to f0d62c8 Compare April 20, 2022 14:24

Changing BslMountPath variable in registry controller

bc86a44

openshift-ci Bot assigned weshayutin Apr 22, 2022

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022

kaovilai added the testing label Apr 29, 2022

kaovilai approved these changes Apr 29, 2022

View reviewed changes

kaovilai merged commit 69ce063 into openshift:master Apr 29, 2022

kaovilai mentioned this pull request Apr 30, 2022

B/R e2e add velero restic DC workaround, describe, namespace events, wait for CSI snapshot to be ready, IsDCReady wait for builds, azure-rg #654

Merged

8 tasks

Uh oh!

Conversation

deepakraj1997 commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Mar 2, 2022

Uh oh!

deepakraj1997 commented Mar 2, 2022

Uh oh!

deepakraj1997 commented Mar 2, 2022

Uh oh!

deepakraj1997 commented Mar 3, 2022

Uh oh!

deepakraj1997 commented Mar 4, 2022

Uh oh!

deepakraj1997 commented Mar 4, 2022

Uh oh!

deepakraj1997 commented Mar 7, 2022

Uh oh!

deepakraj1997 commented Mar 8, 2022

Uh oh!

deepakraj1997 commented Mar 23, 2022

Uh oh!

deepakraj1997 commented Mar 28, 2022

Uh oh!

deepakraj1997 commented Mar 28, 2022

Uh oh!

deepakraj1997 commented Mar 29, 2022

Uh oh!

deepakraj1997 commented Mar 29, 2022

Uh oh!

deepakraj1997 commented Mar 29, 2022

Uh oh!

deepakraj1997 commented Mar 31, 2022

Uh oh!

deepakraj1997 commented Mar 31, 2022

Uh oh!

weshayutin commented Apr 18, 2022

Uh oh!

kaovilai commented Apr 19, 2022

Uh oh!

deepakraj1997 commented Apr 20, 2022

Uh oh!

deepakraj1997 commented Apr 21, 2022

Uh oh!

deepakraj1997 commented Apr 21, 2022

Uh oh!

openshift-ci Bot commented Apr 21, 2022

Uh oh!

weshayutin commented Apr 22, 2022

Uh oh!

kaovilai commented Apr 29, 2022

Uh oh!

kaovilai commented Apr 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

deepakraj1997 commented Mar 2, 2022 •

edited

Loading