Skip to content

Registry credentials can use different secret names when using config["credentialsFile"] - #651

Closed
kaovilai wants to merge 1 commit into
openshift:masterfrom
kaovilai:just_registryCanUseOtherSecretNameFor_credentialsFile
Closed

kaovilai wants to merge 1 commit into
openshift:masterfrom
kaovilai:just_registryCanUseOtherSecretNameFor_credentialsFile

Conversation

@kaovilai

@kaovilai kaovilai commented Apr 29, 2022 •

Copy link
Copy Markdown
Member

@kaovilai
kaovilai force-pushed the just_registryCanUseOtherSecretNameFor_credentialsFile branch from 204f2d9 to a05909a Compare April 29, 2022 01:59
@kaovilai kaovilai changed the title Registry credentials can use other secret names Registry credentials can use different secret names when using credentialsFile Apr 29, 2022
@kaovilai kaovilai changed the title Registry credentials can use different secret names when using credentialsFile Registry credentials can use different secret names when using config["credentialsFile"] Apr 29, 2022
@kaovilai
kaovilai force-pushed the just_registryCanUseOtherSecretNameFor_credentialsFile branch from a05909a to 5a2bf0b Compare April 29, 2022 05:15
@kaovilai

Copy link
Copy Markdown
Member Author

/retest

3 similar comments
@kaovilai

Copy link
Copy Markdown
Member Author

/retest

@kaovilai

Copy link
Copy Markdown
Member Author

/retest

@kaovilai

Copy link
Copy Markdown
Member Author

/retest

@kaovilai

Copy link
Copy Markdown
Member Author

/retest

@openshift-ci

openshift-ci Bot commented Apr 29, 2022

Copy link
Copy Markdown

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai

Copy link
Copy Markdown
Member Author

5 retest later. Beautiful

@kaovilai
kaovilai requested review from deepakraj1997 and shubham-pampattiwar and removed request for JaydipGabani and shawn-hurley April 29, 2022 21:24
@kaovilai

kaovilai commented May 2, 2022

Copy link
Copy Markdown
Member Author

Closing in favor of #652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant