templates/mco: update template to replace setupetcdenv image with MCO image #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from kikisdeliveryservice:setupetcenv-image

Jul 3, 2019

Contributor

kikisdeliveryservice commented Jun 26, 2019 •

edited

Loading

Operator.go & bootstrap.go need to reference the MCO image instead of the
old setupetcdenv image.

Update template to add setupetcdenv entrypoint for MCO image.

Required-for: openshift/installer#1875
Related-to: #850
Related-to: #739 (issue will only close when final installer pr merges)

kikisdeliveryservice requested a review from runcom

June 26, 2019 20:30

openshift-ci-robot added the size/XS label

openshift-ci-robot requested review from ashcrow and ericavonb

June 26, 2019 20:30

openshift-ci-robot added the approved label

kikisdeliveryservice changed the title ~~templates: update template to replace setupetcdenv image with MCO image~~ [WIP] templates: update template to replace setupetcdenv image with MCO image

openshift-ci-robot added the do-not-merge/work-in-progress label

Member

runcom commented Jun 26, 2019

/approve

kikisdeliveryservice force-pushed the setupetcenv-image branch from 8dd4bf9 to a3457a3 Compare

June 26, 2019 20:36

kikisdeliveryservice changed the title ~~[WIP] templates: update template to replace setupetcdenv image with MCO image~~ templates: update template to replace setupetcdenv image with MCO image

openshift-ci-robot removed the do-not-merge/work-in-progress label

ericavonb commented Jun 26, 2019

/lgtm

openshift-ci-robot assigned ericavonb

openshift-ci-robot added the lgtm label

Contributor

openshift-bot commented Jun 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

runcom reviewed

View reviewed changes

templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml Outdated Show resolved Hide resolved

Contributor

openshift-bot commented Jun 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor Author

kikisdeliveryservice commented Jun 26, 2019 •

edited

Loading

@runcom Other people are seeing this failure in BZ: 1724346 other people are seeing the same: hyperkube[1339]: E0626 21:47:25.979131 1339 runtime.go:69] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference) as this pr starting early today. Will investigate more.

Contributor

openshift-bot commented Jun 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments

Contributor

openshift-bot commented Jun 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jun 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

kikisdeliveryservice force-pushed the setupetcenv-image branch from a3457a3 to 3c5b793 Compare

June 27, 2019 02:08

openshift-ci-robot removed the lgtm label

Contributor Author

kikisdeliveryservice commented Jun 27, 2019

(Pushed a commit updating the author date to stop the bot's /retest insanity for now.)

Contributor Author

kikisdeliveryservice commented Jun 27, 2019

Hitting BZ 1724346

See in tests logs e2e-aws: artifacts/e2e-aws/installer/logbundle..../bootstrap/journals/kubelet.log :
Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer

Contributor Author

kikisdeliveryservice commented Jun 27, 2019

namespace deleted, trying again

/retest

kikisdeliveryservice mentioned this pull request

API Updates #898

Merged

Member

runcom commented Jul 2, 2019

/retest

Member

runcom commented Jul 2, 2019

This 100% fails with that panic 🤔 I'm wondering if something else is going on here (but upgrade passed!)

openshift-ci-robot added size/M and removed size/XS labels

kikisdeliveryservice force-pushed the setupetcenv-image branch from 2f32f2d to cdcd1d2 Compare

July 2, 2019 22:35

openshift-ci-robot added size/XS and removed size/M labels

kikisdeliveryservice force-pushed the setupetcenv-image branch 3 times, most recently from bf9f810 to abedb3d Compare

July 3, 2019 00:27

Contributor Author

kikisdeliveryservice commented Jul 3, 2019 •

edited

Loading

Ok I can confirm that the problem is this branch. The mco image isn't being passed in, in the template- templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml- (tho it is passed elsewhere successfully from the bootstrap.go/operator.go):

Jul 02 22:28:13 ip-10-0-134-0 hyperkube[1002]: I0702 22:28:13.014075 1002 kuberuntime_manager.go:617] computePodActions got {KillPod:false CreateSandbox:false SandboxID:08f5fe55cac2d4092e184e2c95436da69e0e4f14e557c5196535127ae9992919 Attempt:0 NextInitContainerToStart:&Container{Name:discovery,Image:<no value>,Command:[/usr/bin/setup-etcd-environment],Args:[run --discovery-srv=ci-op-2y2yd539-c4a31.origin-ci-int-aws.dev.rhcloud.com --output-file=/run/etcd/environment --v=4],WorkingDir:,Ports:[],Env:

Key part: "Image: < no value > ,Command:[/usr/bin/setup-etcd-environment]"

This is from the template where I have: Images.MachineConfigOperator that value isn't being passed somehow.

The above is from controlplane/1.1.somenumber/journals/kubelet.log

UPDATE: I think I got it..

kikisdeliveryservice force-pushed the setupetcenv-image branch from abedb3d to cdd6809 Compare

July 3, 2019 00:44

kikisdeliveryservice commented

View reviewed changes

templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml Outdated

    
                    initContainers:

                    - name: discovery

                      image: "{{.Images.setupEtcdEnv}}"

                      image: "{{.Images.machineConfigOperator}}"

Contributor Author

kikisdeliveryservice Jul 3, 2019 •

edited

Loading

so there's an issue here that is still failing. I thought I found a fix by subbing MachineConfigOperator -> machineConfigOperator I did this bc I noticed the image referenced was setupEtcdEnv and kubeClientAgentImage which is from https://github.com/openshift/machine-config-operator/blob/master/install/0000_80_machine-config-operator_02_images.configmap.yaml as opposed to images.go like elsewhere. I think this change is correct, but there is something missing for this machineconfigoperator image to be seen from the templates/ and im really not sure why?

Contributor Author

kikisdeliveryservice Jul 3, 2019

is this image somehow referenced before it has a value? (since this is in a different place than the other mc* images)

kikisdeliveryservice force-pushed the setupetcenv-image branch from 9b94309 to cdd6809 Compare

July 3, 2019 03:55

runcom reviewed

View reviewed changes

templates/master/00-master/_base/files/etc-kubernetes-manifests-etcd-member.yaml Outdated Show resolved Hide resolved

runcom mentioned this pull request

[DO NOT MERGE] smoke test for 899 #915

Closed

runcom mentioned this pull request

pkg/operator: clarify MCO images and use better names #920

Merged

kikisdeliveryservice force-pushed the setupetcenv-image branch 2 times, most recently from 28f6171 to 6569f91 Compare

July 3, 2019 15:51


          update operator.go/bootstrap.go to remove setup etcd env

Operator.go & bootstrap.go need to reference the MCO image instead of the
old setupetcdenv image.

Update template to add setupetcdenv entrypoint for MCO image.

Required-for: openshift/installer#1875
Related-to: openshift#850
Related-to: openshift#739 (issue will only close when final installer pr merges)

kikisdeliveryservice force-pushed the setupetcenv-image branch from 6569f91 to 6189792 Compare

July 3, 2019 15:54

Member

runcom commented Jul 3, 2019

/lgtm

openshift-ci-robot assigned runcom

openshift-ci-robot added the lgtm label

Contributor

openshift-ci-robot commented Jul 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericavonb, kikisdeliveryservice, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ericavonb,kikisdeliveryservice,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-robot merged commit 253ed18 into openshift:master

runcom added a commit to runcom/machine-config-operator that referenced this pull request


          pkg/operator: clarify MCO images and use better names

47c4801

Honestly finding images in the struct confusing as it's really the
collection of two different sets of images (renderConfig and
ControllerConfig).
This also led to some hassles around changing images in openshift#899 for
instance.
This patch adds some comments around the scope of the images, split the
set in two different ones (still tied to the original struct) and change
the template keys used to substite.

kikisdeliveryservice mentioned this pull request

Fold MCO images into one #739

Closed

kikisdeliveryservice deleted the setupetcenv-image branch

July 10, 2019 17:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/XS